Hyphen in custom post type breaks admin pagination

[ejdanderson]

Custom post types with a hyphen (possibly other non-alphabetical/numeric) in their name break pagination on the admin side. I was unable to navigate past the first page and I could not set the screen option to display a custom number of posts per page.

Since sanitize_key() allows hyphens, we should probably handle this.

Since this is not a recent regression and there is an easy workaround for plugin authors, let's punt this to 3.2 instead of addressing for 3.1.

After a little more testing and initially setting this ticket to invalid, I found that it was not the hyphen breaking the pagination but rather the has_archive argument. See ticket:16013

The hyphen does appear to break the ability to set the show on screen number.

#16064

Would like to see this fixed in 3.2, as ryan wants to punt it to 3.2.

Note that this affects not only post types but also taxonomies with hyphens in name.

Closed as duplicate: #16064

Patch still applies clean.

Refreshed patch

With @access private

See also #18958

Since #18958 has some commits against it, I'll mark this ticket as a dupe.