Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#15974 closed defect (bug) (fixed)

RTL audit

Reported by: nacin Owned by:
Priority: normal Milestone: 3.1
Component: RTL Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

Attachments (2)

15974.diff (2.5 KB) - added by nacin 2 years ago.
pagination.rtl.patch (2.3 KB) - added by yoavf 2 years ago.

Download all attachments as: .zip

Change History (16)

nacin2 years ago

Patch attached. I imagine there is a better way to do this, as I had to mess with the direction property to prevent the browser from rearranging the inline elements. I just don't know enough about RTL in browsers.

Patch has two additional enhancements:

  • Fixes the %s of %s paging translation to allow argument swapping.
  • Moves to lsaquo and rsaquo, rather than double raquo. Looks much more compact and cleaner. Not sure if we need to allow these to be translated, to avoid using these characters in certain languages. (Ideally, we should probably go with a presentational image.)

site-themes.php and site-users.php need nonce checks.

Wrong ticket for that last comment.

  • Keywords has-patch commit added

Tested internal linking, the admin bar, the network admin. Did a quick sweep through all the admin screens, checking the list tables.

Per a quick grep, it looks like the direction: ltr and direction: rtl trick is pretty common. Going to mark for commit and closed.

  • Resolution set to fixed
  • Status changed from new to closed

(In [17139]) RTL for the new style pagination links. fixes #15974.

Patch is IE6 and Opera save.

Edit: Oh, already committed, my bad.

Last edited 2 years ago by ocean90 (previous) (diff)

Nope, thanks for the confirmation. I convinced someone to test on IE6, and I handled Opera :-)

yoavf2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The screenshot in the ticket description isn't valid - the browser renders it this way when there's ltr text instead of rtl text.
Replace (for example using firebug) the text with hebrew text and it all comes in to place.

pagination.rtl.patch is a reverse diff + small addition for the .list-ajax-loading css.
Tested with webkit/ff/ie7+/opera

To confirm, feel free to replace "items" with "פריטים" or any other rtl text.

yoavf, thx for you comment/patch. After replacing "items" with "פריטים" it looks good.

Would be nice, if you could give us a link to a rtl language file, if there is one.

http://translate.wordpress.org/projects/wp/dev/ms/ar/default
http://translate.wordpress.org/projects/wp/dev/ar/default

Last edited 2 years ago by ocean90 (previous) (diff)

Hebrew WP 3.0.3, as a package, is available here: http://he.wordpress.org/wordpress-3.0.3-he_IL.zip

Translation is also available at http://translate.wordpress.org/projects/wp/dev/he/default - not sure if there's a direct link to the po/mo files.
This string ("items") isn't translated yet, btw.

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17152]) RTL pagination fixes. Props yoavf. fixes #15974

(In [17153]) RTL pagination fixes. Props yoavf. fixes #15974

(In [17154]) RTL pagination fixes. Props yoavf. fixes #15974

Note: See TracTickets for help on using tickets.