Invited Users Can Disappear in MS

[filosofo]

Steps to reproduce:

• In Site Admin, go to Users > Add New
• Add a new user
• You get a message to the effect of, said user needs to respond to an invitation.

Now the user has disappeared. There's no way for a super admin or anybody to search for that user and add her directly, or delete her, or anything like that. If the user doesn't get the email, she's out of luck: that username and email are now reserved for "a couple of days."

I think these limbo users should show up in the Network Admin list of users. If there's some agreement I can make a patch.

Nothing new.

But I would prefere a list here too, maybe as a filter Pending on network/users.php and some action links like Send email again or Delete.

Replying to ocean90:

Nothing new.

I don't think that's the case. In 3.0.x you cannot create a user in the admin that disappears. If I'm wrong, please give me the steps to reproduce. In the past, when you create a user in admin, it's there.

That's what makes this a regression.

Check on network options Allow site administrators to add new users to their site via the "Users->Add New" page.

Then go to wp-admin/user-new.php and add a user but don't check Site administrators can add a user without sending the confirmation email.

You cannot see the user on any list.

If you want to add the same user again, you get the message That username is currently reserved but may be available in a couple of days.

Ok. Even if it's not new, it's still a bug.

I would argue that it's much worse in 3.1 because it's easier to do, as it's allowed by default.

first attempt to patch this bug

I attached my first attempt to patch this bug. As I'm not yet familiar with the inner workings of multisite user system, I'm sure there's a lot of room for improvement (or even a total different approach). But I'd like to take a stab at fixing this and pick up a few things along the way, hence, 16001.diff .

There are a few issues / questions:

• user_login is not indexed in table wp_signups. There's also no ID column. As a result, querying, updating and deleting on this table based on user_login might be a performance hit.

• I don't know if wp_signups ever gets cleaned up (those items where active = 1)? If it does, could you point me to the code that does it?

pending user filter

bulk edit pending users

Replying to garyc40:

• I don't know if wp_signups ever gets cleaned up (those items where active = 1)? If it does, could you point me to the code that does it?

I was just wondering about this myself. wpmu_delete_user() doesn't appear to delete the accompanying data in the wp_signups table and was wondering if there was an underlying reason.

Closed #20817 as a duplicate.

I had to piece this patch together with my bare hands based on the old one, but I think this feature makes total sense and is a rare ray of hope in the dark gloomy world of Multisite - 3.2-early alum

Too late for this now, but I like it, so let's take another look early 3.7.