Opened 2 years ago
Last modified 32 hours ago
#16055 new defect (bug)
Only fire 'Site Wide Only' plugin header deprecated notice if the plugin is activated
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Plugins | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch 2nd-opinion |
| Cc: |
Description
Apparently it can be fired on a deactivated plugin. That's annoying and confusing.
Attachments (1)
Change History (4)
comment:3
DrewAPicture — 32 hours ago
- Summary changed from Only fire 'Side Wide Only' plugin header deprecated notice if the plugin is activated to Only fire 'Site Wide Only' plugin header deprecated notice if the plugin is activated
Note: See
TracTickets for help on using
tickets.
Coming back to this, I'm not actually sure if this is a bad thing after all. The notice is clear about which plugin it is. In general, these notices are annoying anyway — I don't think if this plugin was activated would it be any less annoying or confusing. And because plugins can be activated on *other* sites in a network, it's kinda important to make sure the header is up to date and not using deprecated behavior.
A note on the stale patch here — that change in the conditional also affects $plugin_data['Network'] = $plugin_data['_sitewide'];, which would still need to apply in case the plugin was inactive.
Any thoughts, DJPaul, as a BuddyPress (which is Network: true) core dev?