Opened 2 years ago
Last modified 20 months ago
#16162 reopened defect (bug)
Pagination and sorting reset after bulk media deletion
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Administration | Version: | 3.1 |
| Severity: | normal | Keywords: | needs-patch |
| Cc: | WordPress@… |
Description (last modified by scribu)
When doing Bulk Deletes on paginated Media Library, after performing the delete, I'm back on page 1 regardless on which page I've been before.
Attachments (2)
Change History (19)
comment:2
ocean90
— 2 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.1
- Owner set to scribu
- Status changed from new to reviewing
Same for categories and tags page. If we have it for posts and comments (#15416), we should add it with the other pages too.
comment:4
hakre
— 2 years ago
It does not reflect the sort column as well.
paged is part of the request, orderby and order are not.
comment:5
hakre
— 2 years ago
The patch preserves paged for bulk media deletes. sorting is not preserved as it does not gets passed in the request.
The idea I had so far is to add hidden form fields or to change the forms action attribute when things are changed by javascript.
The only hotfix I know of so far is to disable javascript which makes one of the biggest improvements of 3.1 looking pretty reduced.
comment:6
scribu
— 2 years ago
- Description modified (diff)
- Summary changed from Bulk Actions and Pagination: Page Lost to Pagination and sorting reset after bulk media deletion
comment:7
SergeyBiryukov
— 2 years ago
- Keywords has-patch added; needs-patch removed
hakre's patch works for me.
comment:8
voyagerfan5761
— 2 years ago
- Cc WordPress@… added
comment:9
nacin
— 2 years ago
- Keywords needs-patch added; has-patch removed
Noting that ocean90 was also able to reproduce this against edit-tags.php. A few of us were looking at this today (MarkJaquith in particular) and pagination was inconsistent across a number of screens.
SergeyBiryukov
— 2 years ago
comment:10
SergeyBiryukov
— 2 years ago
Tried to take a stab at it.
comment:11
SergeyBiryukov
— 2 years ago
Looks like the Plugins screen is affected too. Are there any else?
comment:12
garyc40
— 2 years ago
My patch over here also fixes pagination and sort reset for edit-tags, edit-comments, edit .
garyc40.16166.2.diff
Perhaps we should merge this ticket and #16166?
comment:13
scribu
— 2 years ago
- Owner scribu deleted
comment:14
dd32
— 2 years ago
- Milestone 3.1 deleted
- Resolution set to duplicate
- Status changed from reviewing to closed
Combining this, as the patch over on 16162 should fix this once it's applied to the rest of the list tables.
Duplicate of #16162
comment:16
ryno267
— 20 months ago
This is still an issue and imo shouldn't be merged with the ajax ticket. Any resolution to this
comment:17
scribu
— 20 months ago
- Milestone set to Future Release
- Resolution duplicate deleted
- Status changed from closed to reopened
Yeah, need to handle this either way.
Related: #15416