Opened 2 years ago

Last modified 19 months ago

#16162 reopened defect (bug)

Pagination and sorting reset after bulk media deletion

Reported by: hakre Owned by:
Priority: normal Milestone: Future Release
Component: Administration Version: 3.1
Severity: normal Keywords: needs-patch
Cc: WordPress@…

Description (last modified by scribu)

When doing Bulk Deletes on paginated Media Library, after performing the delete, I'm back on page 1 regardless on which page I've been before.

Attachments (2)

16162-paged.patch (469 bytes) - added by hakre 2 years ago.
preserve paged
16162.2.patch (1.2 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (19)

  • Component changed from General to Administration

Related: #15416

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.1
  • Owner set to scribu
  • Status changed from new to reviewing

Same for categories and tags page. If we have it for posts and comments (#15416), we should add it with the other pages too.

Last edited 2 years ago by ocean90 (previous) (diff)

I was able to reproduce against latest trunk.

It does not reflect the sort column as well.

Version 0, edited 2 years ago by hakre (next)

hakre2 years ago

preserve paged

The patch preserves paged for bulk media deletes. sorting is not preserved as it does not gets passed in the request.

The idea I had so far is to add hidden form fields or to change the forms action attribute when things are changed by javascript.

The only hotfix I know of so far is to disable javascript which makes one of the biggest improvements of 3.1 looking pretty reduced.

  • Description modified (diff)
  • Summary changed from Bulk Actions and Pagination: Page Lost to Pagination and sorting reset after bulk media deletion
  • Keywords has-patch added; needs-patch removed

hakre's patch works for me.

  • Cc WordPress@… added
  • Keywords needs-patch added; has-patch removed

Noting that ocean90 was also able to reproduce this against edit-tags.php. A few of us were looking at this today (MarkJaquith in particular) and pagination was inconsistent across a number of screens.

Tried to take a stab at it.

Looks like the Plugins screen is affected too. Are there any else?

My patch over here also fixes pagination and sort reset for edit-tags, edit-comments, edit .
garyc40.16166.2.diff

Perhaps we should merge this ticket and #16166?

  • Owner scribu deleted
  • Milestone 3.1 deleted
  • Resolution set to duplicate
  • Status changed from reviewing to closed

Combining this, as the patch over on 16162 should fix this once it's applied to the rest of the list tables.

Duplicate of #16162

Replying to dd32:

Combining this, as the patch over on 16162 should fix this once it's applied to the rest of the list tables.

Duplicate of #16162


s/#16162/#16166/

Last edited 2 years ago by ocean90 (previous) (diff)

This is still an issue and imo shouldn't be merged with the ajax ticket. Any resolution to this

  • Milestone set to Future Release
  • Resolution duplicate deleted
  • Status changed from closed to reopened

Yeah, need to handle this either way.

Note: See TracTickets for help on using tickets.