Opened 2 years ago
Closed 4 months ago
#16206 closed defect (bug) (wontfix)
Commenttext not marked as required
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Comments | Version: | 3.0.4 |
| Severity: | normal | Keywords: | has-patch 2nd-opinion |
| Cc: | mdhansen@… |
Description
I thought i already opened a ticket to this but i cant find it... Maybe i didnt hit the create ticket button?!
When using comment_form() the name and email fields marked as required while the textarea for commenttext is not. If i send my comment without text i'll get this notice
Error: please type a comment.
So it also should be marked as required field.
Attachments (1)
Change History (10)
- Keywords 3.2-early needs-patch added; comment, commenttext, required removed
- Milestone changed from Awaiting Review to Future Release
comment:2
solarissmoke — 2 years ago
- Keywords has-patch added; needs-patch removed
Looks like maybe my comment either got stopped by dd32's, or I was commenting to the other phantom ticket. Looks like the former.
Anyway, I don't mind adding aria-required, but the * seems just redundant and silly. Mentioned it to MarkJaquith and a few others and I seemed to recall them nodding in agreement on that.
- Keywords 2nd-opinion added; 3.2-early removed
Ah, comment text already has aria-required.
My opinion: Either the field is required (the error notice is saying that) then the * isn´t redundant, otherwise it isn´t a required field. Maybe the code already has an aria-required but visitors don´t look into the code for required fields. ;-)
Replying to infected:
Maybe the code already has an aria-required but visitors don´t look into the code for required fields. ;-)
I guess in the case of a comment text that's just implied by common sense.
Replying to SergeyBiryukov:
I guess in the case of a comment text that's just implied by common sense.
From this point of view, yes. It's just a cosmetic thing...
comment:8
in reply to:
↑ 6
MikeHansenMe — 4 months ago
- Cc mdhansen@… added
- Keywords close added
Replying to SergeyBiryukov:
Replying to infected:
Maybe the code already has an aria-required but visitors don´t look into the code for required fields. ;-)
I guess in the case of a comment text that's just implied by common sense.
I would agree that the comment field is common sense. Proposing close
comment:9
SergeyBiryukov — 4 months ago
- Keywords close removed
- Milestone Future Release deleted
- Resolution set to wontfix
- Status changed from new to closed

Sounds like a good idea, Kind of should be consistent in the forms :)