Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#16211 closed defect (bug) (fixed)

In the admin bar, use ids instead of unique classes

Reported by: koopersmith Owned by: koopersmith
Priority: normal Milestone: 3.1
Component: Administration Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Description

Using unique classes in the admin bar makes plugin developers' lives more difficult, and runs contrary to conventional wisdom. Let's fix that.

Also, we should be using esc_attr on the class.

Attachments (2)

16211.diff​ (2.8 KB) - added by koopersmith 2 years ago.
16211.2.diff​ (3.3 KB) - added by koopersmith 2 years ago.

Download all attachments as: .zip

Change History (5)

koopersmith — 2 years ago

comment:1   koopersmith — 2 years ago

  • Keywords has-patch added

koopersmith — 2 years ago

comment:2   westi — 2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17279]) Add unique ids as well as of classes in the admin bar to make it easier for plugins to extend.
Ensure we escape the classname.
Fixes #16211 props koopersmith.

comment:3   westi — 2 years ago

(In [17280]) Bump script loader versions. See #16211

Note: See TracTickets for help on using tickets.