Hide core updater if running an svn checkout

[johnjamesjacoby]

The logic with this patch is if you are running an svn checkout, do not display the core updater code and instead display a reminder.

Having some sort of svn-specific behavior is definitely something we should do, but disabling the core updater entirely seems error prone. It should just be a warning.

What koop said.

Also, we should do the same per plugin/theme at some point.

How does this do for a simple warning?

I'd throw an ABSPATH in there at least. Someone else might like to weigh in on the wording.

Wouldn't is_directory() be more appropriate?

Wouldn't is_directory() be more appropriate?

Yeah, I suppose it would, have changed it.

I believe WordPress is spelled wrong here :-)

Everyone's allowed to make that mistake once, right? :P

Since we're at it, how about checking for a .git directory too? :D

Add ABSPATH, use is_dir(), and capital P, dangit!

There we go. I thought about customising the string for SVN and Git, but it seems like overkill.

If we are to offer Git checkout detection, which I'm not inclined to do, I'd rather not combine the string.

Also, let's spell out "Subversion". My take: <strong>Warning:</strong> It appears that you are running Subversion checkout of WordPress. You may wish to keep WordPress up to date using Subversion instead.

Also, please don't replace patches -- just upload new ones.

Also, please don't replace patches -- just upload new ones.

Okay.

If we are to offer Git checkout detection, which I'm not inclined to do

I agree here, Support the VCS we're using, we can't support every single VCS out there..

attachment warning.jpg added

• demo of 16216.3.diff for UI feedback.

Missed freeze, punting.