Ticket #16302 (closed defect (bug): fixed)

Opened 13 months ago

Last modified 7 weeks ago

Don't shout booleans

Reported by: westi Owned by: westi
Priority: normal Milestone: 3.4
Component: Warnings/Notices Version: 3.1
Severity: normal Keywords: has-patch 3.2-early
Cc: chris@…

Description

In a number of places in core WP or external libraries we shout our booleans as TRUE and FALSE instead of true and false.

We shouldn't in core WP.

No patch because search and replace can fixor this.

Attachments

16302.diff Download (51.3 KB) - added by c3mdigital 13 months ago.
16302.null.diff Download (10.8 KB) - added by mfields 9 months ago.
Lowercase appropriate null values.

Change History

comment:1   nacin — 13 months ago

also NULL vs null.

c3mdigital — 13 months ago

comment:2   c3mdigital — 13 months ago

  • Cc chris@… added
  • Keywords has-patch added; 3.2-early removed

comment:3   SergeyBiryukov — 13 months ago

  • Keywords 3.2-early added

comment:4   nacin — 13 months ago

Looks good.

Most of the external libraries should be avoided here. That includes class-ftp*.php and pclzip.php. kses is fine just because that's no longer really an external library in practice and should follow our standards.

Would also like to see NULL ucase'd in another patch.

comment:5   mfields — 9 months ago

I went through and lowercased all of the null values I came across. I ignored everything that looked like an external library and I did not touch any SQL. Please see 16302.null.diff

mfields — 9 months ago

Lowercase appropriate null values.

comment:6   ryan — 7 weeks ago

  • Milestone changed from Future Release to 3.4

comment:7   ryan — 7 weeks ago

  • Status changed from new to closed
  • Resolution set to fixed

In [19687]:

User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302

Note: See TracTickets for help on using tickets.