Sorting is reset after searching

[scribu]

1. Go to /wp-admin/edit.php
2. Sort by title
3. Search for something

The search results are no longer sorted by title.

All list screens are affected.

for edit.php

16341.diff​ fixes the problem for edit.php, but the same needs to be done for all list screens.

I like Sergey's patch better.

Maybe we should make it a method of WP_List_Table, to avoid code duplication.

Replying to scribu:

Maybe we should make it a method of WP_List_Table, to avoid code duplication.

+1

ocean90: scribu: Wouldn't be something like $wp_list_table->hidden_fields() nice?
scribu: exactly
ocean90: Which has some default fields and is extendable for example for the edit screen (post_type & post_status)
scribu: yep

16341.2.patch​ should do it for Posts, Media Library, Links, Pages, Comments and Users screens. Going to check Network screens.

16341.3.patch​ should do it for Network screens as well.

Fixed themes search on Edit Site screen

Not a fan of all the churn here. Let's just add the method and call it hidden_order_fields(), call it everywhere, and don't bother with any other iterations at this point.

Replying to nacin:

Let's just add the method and call it hidden_order_fields(), call it everywhere, and don't bother with any other iterations at this point.

Done.

16341.6.patch​ may have better formatting in hidden_order_fields().

We can also just sneak the logic into views() probably, as it's called on all the same pages. But thanks for the much simpler patch.

views() is currently called outside of the search forms. Not sure how it would help here.

Perhaps search_box() would be appropriate place?

OK, here's even more simple patch :)

I can agree with hidden_order_fields(), but slapping them onto search_box() is wrong, IMO.

From IRC:

(07:36:52 PM) nacin: scribu: the first thing I'm doing when 3.1 is released is rearchitecting this mess.

So let's go with 16341.7.patch​

(In [17353]) Add orderby and order hidden fields to each list form, to allow for state. props SergeyBiryukov, fixes #16341.