Opened 2 years ago

Last modified 2 years ago

#16345 reopened defect (bug)

Some submit buttons shouldn't have names

Reported by: nacin Owned by:
Priority: normal Milestone: Future Release
Component: Administration Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Description

Technically a regression due to the submit_button implementation. What happens instead is the URL gets polluted.

Noticed especially after we moved back to GET on a bunch of screens.

In these cases, we just need the form to be sent. Don't need the context info.

Attachments (2)

16345.diff (1.3 KB) - added by garyc40 2 years ago.
"Search Themes" and "Apply Filters" buttons don't need a name
16345.2.diff (2.3 KB) - added by garyc40 2 years ago.
"Search Users" and "Search Sites" on network dashboard don't need names either

Download all attachments as: .zip

Change History (8)

(In [17349]) Use only an ID, no name, on the 'Filter' buttons on list screens. see #16345.

  • Resolution set to fixed
  • Status changed from new to closed

(In [17352]) doaction buttons don't need a name, only an ID. fixes #16345.

Related: #16364

garyc402 years ago

"Search Themes" and "Apply Filters" buttons don't need a name

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

"Search Themes" and "Apply Filters" button in wp-admin/themes.php don't need a name as well. Patch attached.

garyc402 years ago

"Search Users" and "Search Sites" on network dashboard don't need names either

These don't look like regressions though. The theme search form wasn't even there in 3.0.x .

Version 0, edited 2 years ago by garyc40 (next)
  • Milestone changed from 3.1 to Future Release

If they're not regressions, and don't cause problems, let's leave them alone for 3.1.

Note: See TracTickets for help on using tickets.