Opened 2 years ago

Closed 19 months ago

#16380 closed defect (bug) (fixed)

Whitespace missing between strings

Reported by: johnbillion Owned by: ryan
Priority: normal Milestone: 3.3
Component: Administration Version: 3.1
Severity: trivial Keywords: has-patch
Cc: olleicua@…

Description

If you bulk edit some posts and some (but not all) are locked due to being edited by another user, the resulting message lacks whitespace between the strings.

To reproduce, simply visit http://example.com/wp-admin/edit.php?updated=1&skipped=0&locked=1 .

Attachments (5)

capture.png (5.6 KB) - added by johnbillion 2 years ago.
16380.patch (798 bytes) - added by johnbillion 2 years ago.
patch
16380.diff (696 bytes) - added by solarissmoke 2 years ago.
16380.2.patch (802 bytes) - added by SergeyBiryukov 2 years ago.
16380.3.patch (802 bytes) - added by SergeyBiryukov 22 months ago.

Download all attachments as: .zip

Change History (14)

patch

  • Version set to 3.1

Patch. String change I'm afraid.

Also, there should be a Trac ticket severity lower than "trivial". Something like "Nobody is ever going to notice this and if they do they won't care anyway".

  • Milestone changed from Awaiting Review to Future Release

This shouldn't need a string change. Leading and trailing whitespace should be avoided, especially for deliberate use. We can probably just echo a space somewhere.

  • Keywords has-patch added

I'd prefer to add the space after "% posts updated" rather than at the beginning of "%s items not updated".

There's always the case when all the posts that the user attempt to update are already being edited by someone. So your patch would result in an extra space at the beginning of the message.

That makes sense

  • Milestone changed from Future Release to 3.3

Refreshed for 3.3.

Tested, certainly works.

  • Cc olleicua@… added
  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19259]:

Fix message concatentation. Remove no longer used 'posted' message. fixes #16380

Note: See TracTickets for help on using tickets.