Opened 2 years ago
Last modified 23 months ago
#16448 new enhancement
Smilies should not be placed inside of pre or code tags
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Formatting | Version: | 3.1 |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: |
Description
Smilies should ignore content inside of <pre> and <code> tags. The author likely is posting code and doesn't need smilies messing it up.
Attachments (1)
Change History (7)
comment:1
solarissmoke — 2 years ago
- Keywords has-patch needs-testing added; needs-patch removed
solarissmoke — 2 years ago
comment:2
follow-up:
↓ 3
Viper007Bond — 2 years ago
We'll need to make sure to run any patch through unit tests of course BTW. Gotta make sure it's not significantly slower, etc.
Replying to Viper007Bond:
We'll need to make sure to run any patch through unit tests of course BTW. Gotta make sure it's not significantly slower, etc.
Indeed, unfortunately we don't have any similes tests yet - http://unit-tests.trac.wordpress.org/browser/wp-testcase/test_includes_formatting.php
Anyone fancy writing some ;)
comment:4
follow-up:
↓ 6
jakub.tyrcha — 23 months ago
See http://gsoc.svn.wordpress.org/2011/jakub.tyrcha for unit tests testing this and a few more things
comment:5
jakub.tyrcha — 23 months ago
I'm pretty sure it fails on the line containing <code style="color:#fff">
Replying to jakub.tyrcha:
See http://gsoc.svn.wordpress.org/2011/jakub.tyrcha for unit tests testing this and a few more things
Please could you create a ticket in the unit-tests trac and attach the patch there too.
Don't mess with smilies in code and pre blocks