Ticket #16468 (new defect (bug))

Opened 16 months ago

Last modified 16 months ago

404 page with /page/2 shows page #

Reported by: rob1n Owned by:
Priority: normal Milestone: Awaiting Review
Component: Themes Version: 3.0
Severity: minor Keywords: has-patch
Cc:

Description

In 2010, there's a custom part of the title that shows " | Page 2" etc for paged posts.

Yet, even if it's a 404, it still shows this if there's a $page or $paged variable.

e.g. /2012/04/page/2 (picked to obviously 404) is: Page not found | robinadr | Page 2 on my site.

Checked trunk, same problem there.

Attachments

paged-404.diff Download (500 bytes) - added by rob1n 16 months ago.

Change History

rob1n16 months ago

  • Cc robin.adr@… added
  • Version changed from 3.1 to 3.0

It'd be great to have a helper to prevent the page/paged conditional as well as the max() call. Like get_queried_page_num() and has_multiple_pages() (for other checks in the theme).

  • Cc robin.adr@… removed

Yeah, having to global those variables and do the max() handling in a theme seems clumsy.

How about is_paged() and get_current_page_number()?

We already have is_paged(), which checks the is_paged query flag. I think we need more for when it is instead the page query variable.

Note: See TracTickets for help on using tickets.