Opened 2 years ago

Last modified 2 months ago

#16483 new defect (bug)

Visibility: password-protected exposes multiple pages

Reported by: monkeyhouse Owned by:
Priority: normal Milestone: Future Release
Component: Security Version: 3.0.4
Severity: minor Keywords: has-patch dev-feedback needs-testing
Cc: mdhansen@…

Description

  1. password protect a page ('protected') with a password
  2. password protect another page ('thistoo') with the SAME password
  3. visit 'protected' and enter the password. Page is visible
  4. visit 'thistoo'; expected: prompt for password. What happens: Page is visible

Regardless of whether someone with a password has the right to try it in as many pages as they want (and would therefore successfully see the page if the passwords were the same), the user should still be prompted on a page-by-page basis. Global authentication to multiple pages is possible with user accounts and roles. It should not be possible with visibility: password-protected pages.

Attachments (5)

16483.diff (2.6 KB) - added by solarissmoke 2 years ago.
Make passwords post-specific
16483.2.diff (2.9 KB) - added by garyc40 2 years ago.
modified solarissmoke's patch a bit: no notice when not called inside a loop
16483.3.diff (2.1 KB) - added by SergeyBiryukov 6 months ago.
16483.4.diff (2.9 KB) - added by SergeyBiryukov 4 months ago.
16483.5.diff (2.9 KB) - added by SergeyBiryukov 3 months ago.
Refreshed

Download all attachments as: .zip

Change History (12)

Make passwords post-specific

  • Keywords has-patch dev-feedback added

I agree that this shouldn't happen - although plain text passwords in cookies aren't really going to prevent someone who is determined ;)

Here's one possible patch. It may cause some issues because previously (and since WP 1.0.0) get_the_password_form() didn't require a post. I can't find any instances in core that don't have a post (or implicit post global) set, but I might have missed something.

garyc402 years ago

modified solarissmoke's patch a bit: no notice when not called inside a loop

  • Cc mdhansen@… added
  • Keywords needs-refresh added

This problem still exists in 3.5-RC1-22924. Patch needs refresh.

  • Keywords needs-testing added; needs-refresh removed

comment:4 follow-up: ↓ 5   MikeHansenMe6 months ago

16483.3.diff does not seem to let me log in to the page at all even with the correct password.

comment:5 in reply to: ↑ 4   SergeyBiryukov4 months ago

Replying to MikeHansenMe:

16483.3.diff does not seem to let me log in to the page at all even with the correct password.

Thanks, fixed in 16483.4.diff. Missed [19728] in the previous patch.

  • Component changed from General to Security
  • Milestone changed from Awaiting Review to 3.6

Related: #19797

Refreshed

  • Milestone changed from 3.6 to Future Release

This has been discussed a number of times and there are many who consider this a feature. Punting back to Future Release since it requires negotiations.

Note: See TracTickets for help on using tickets.