Opened 2 years ago
Closed 4 months ago
#16498 closed enhancement (fixed)
simpler printing for "lostpassword" link
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 3.6 |
| Component: | General | Version: | |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: |
Description
There's no need to have two lines that print the same "lostpassword" link in in wp-login.php. Skip the "else" and just print it.
Attachments (4)
Change History (9)
comment:1
markjaquith — 2 years ago
- Milestone changed from Awaiting Review to Future Release
- Milestone changed from Future Release to 3.6
- Priority changed from normal to low
- Type changed from defect (bug) to enhancement
16498.diff is actually incorrect since there are actually 3 conditions here, not two. See 16498.2.patch, where I've made this code a little more clear.
SergeyBiryukov — 4 months ago
comment:3
SergeyBiryukov — 4 months ago
The "Intentionally empty" section (as labeled in 16498.2.patch) was introduced in [6612]. We can rewrite the condition so that there's no need for it.
16498.3.patch is the refreshed lostpassword.patch, which I guess simplifies the logic in the most obvious way.
comment:4
SergeyBiryukov — 4 months ago
- Keywords commit added
comment:5
SergeyBiryukov — 4 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 23336:
Note: See
TracTickets for help on using
tickets.
even better, with the negative mark in the right place