Opened 2 years ago
Closed 8 months ago
#16570 closed defect (bug) (fixed)
Twenty Ten: Second row of pages needs line height
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | WordPress.org |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
Edge case, definitely, but a friend using Twenty Ten for a law review site stumbled across this.
Screenshot attached.
Attachments (3)
Change History (11)
iandstewart
— 2 years ago
comment:1
follow-up:
↓ 6
iandstewart
— 2 years ago
comment:3
SergeyBiryukov
— 19 months ago
- Component changed from Themes to Bundled Theme
- Milestone changed from WordPress.org to 3.3
comment:4
SergeyBiryukov
— 19 months ago
- Milestone changed from 3.3 to WordPress.org
comment:5
follow-up:
↓ 7
mfields
— 10 months ago
Hello. I just noticed that this ticket has been moved to the WordPress.org milestone. What does this mean? Is there a special commit process for older bundled themes?
SergeyBiryukov
— 10 months ago
comment:6
in reply to:
↑ 1
SergeyBiryukov
— 10 months ago
Replying to iandstewart:
Opera 10.6.3 will appear to crop the page-link anchor padding on the leftmost links however.
To be clear, this currently happens without the patch as well: 16570.opera.png.
The patch seems good. Tested in Firefox 14, Chrome 21, IE 8, Opera 12.
comment:7
in reply to:
↑ 5
SergeyBiryukov
— 10 months ago
- Keywords commit added
Replying to mfields:
I just noticed that this ticket has been moved to the WordPress.org milestone. What does this mean? Is there a special commit process for older bundled themes?
It was originally created in the WordPress.org milestone.
My guess is that as long as Twenty Ten is still a bundled theme, the ticket can be fixed via the regular commit process. However, Twenty Ten might be removed from 3.5, so I'm not sure whether the fix can make it into 3.5.
Marking for commit, per the previous comment.
comment:8
lancewillett
— 8 months ago
- Owner set to lancewillett
- Resolution set to fixed
- Status changed from new to closed
In [22216]:
Attached is a patch [page-links-line-height.diff] that adds line-height to page links resolving this issue. Opera 10.6.3 will appear to crop the page-link anchor padding on the leftmost links however. Making the links inline-block elements with margin will resolve that new Opera issue -- and introduce a new display bug in IE7. :) I think this new Opera-only edge-case issue is an improvement though.