CPT archive rewrite rule doesn't respect 'with_front' arg

[scribu]

1. Have WP MS activated, with subdirectories, not subdomains.

1. Register a custom post type, with has_archive => true.

2. On the main blog, call get_post_archive_link().

The URL will include the /blog/ prefix, but it will lead to a 404, since the rewrite rule isn't correct.

The trouble comes from the fact that $wp_rewrite->add_rule is used directly, which doesn't have a $with_front argument.

See 16626.diff​.

Seems that 16626.diff does work. When I previously rec'd a 404 not found error when trying to load a single custom post type. When I used your diff, I am now able to see the post. still uses the /blog url structure, which is another issue though.

still uses the /blog url structure, which is another issue though.

Yes, that's the idea. If you don't want to use /blog, just say so:

register_post_type( ..., array(
  'rewrite' => array( 'with_front' => false ),
  ...
) );

seems that using 16626.diff caused this error though.

Fatal error: Cannot redeclare class Walker_Page in /.../wp-includes/post-template.php on line 1062

Are you sure that's not caused by a plugin or theme?

Walker_Page was moved from wp-includes/classes.php (and that file was killed) to wp-includes/post-template.php. I would make sure your upgrade was complete.

Clearer

Follow-up: #16725

(In [17514]) Use with_front properly when creating rules for CPT archive pages. props scribu. fixes #16626 for trunk

(In [17515]) Use with_front properly when creating rules for CPT archive pages. props scribu. fixes #16626 for 3.1