Internal linking feature is not available when rich text editing is disabled

[laacz]

In plain text editor (at least - when rich-text one is disabled in per-user settings) there is no internal linking feature available. Link button pops up just an link input dialog.

This was done consciously.

Changing to an Enhancement

who worked on this feature for 3.1? Would like to bug them into helping me make a plugin/future patch.

+1. I (we) would love to see this happen. Perhaps I will write a patch.

What I would actually like to see, and have talked about with @koopersmith (who did the internal linking feature, to answer @jsternberg's question), is not replicating internal linking in the html view, but putting linking up on the level of media insertion, so the same thing is available to both. Not in scope for 3.2, but would love for 3.3, and a plugin in the meantime would be great.

Patch adds internal linking to HTML mode. Tested in Chrome, FF, IE8.

We can explore relocating the linking trigger, but that should be done in a separate patch.

Note: The only compressed file is the TinyMCE editor_plugin.js, and there is a new js file, wpdialogs.dev.js (in the js directory inside the tinymce wpdialogs plugin).

(In [17687]) Use wpLink in the HTML editor too, props koopersmith, fixes #16631

Where exactly is this feature in the HTML editor? I can't find it, with or without TinyMCE enabled and with SCRIPT_DEBUG on.

(In [17690]) Update wp-tinymce.js.gz and bump. see #16631.

In Firefox 4, with the visual editor selected, refreshing the edit screen shows both the TinyMCE controls and the HTML controls above it: ​http://i.imgur.com/QMXFn.png

Replying to scribu:

In Firefox 4, with the visual editor selected, refreshing the edit screen shows both the TinyMCE controls and the HTML controls above it: ​http://i.imgur.com/QMXFn.png

I've encountered this error several times before (months ago) and have never been able to pin down the cause. I currently cannot reproduce the error and it usually goes away with a subsequent refresh/cleared cache/browser restart.

Is this happening consistently? Are there any signs pointing to this changeset?

It's still happening today and it only started happening after [17690].

I have SCRIPT_DEBUG on and I've refreshed and restarted the browser several times.

If I switch to HTML mode and then back to visual mode, it goes away.

Replying to scribu:

Does it happen in all browsers or only FF 4? Also can you check it with Firebug (or similar) if it's the same <div id="quicktags"... or there is a second one on page load.

It seems to also happen in Chrome (can't test other browsers atm).

Yes, it's the same div. The code that's supposed to hide it just doesn't seem to fire initially.

Also: no plugins active and using twentyten theme.

It happens to me too, but only in FF4. I tested (on Windows):

• Opera 11
• Chrome 11
• IE 9
• Safari 5

Like scribu said, changing tabs fixes the issue, but on the page load it's messed up.

Didn't make it in before freeze, punting.

This is in trunk. Anything left, koopersmith?

All good. If the double-toolbar bug keeps cropping up, please open a new ticket.