[15825] Changed the format of our category links from ?cat=123 to ?category_name=slug

[markjaquith]

Before [15825], default category links used the ID (?cat=123). After [15825], they started using ?category_name=slug. There are no canonical redirects.

When you say "no canonical redirects", do you mean one of the links doesn't work at all, or just that neither link is 301-ing to the other?

Replying to bigonroad:

When you say "no canonical redirects", do you mean one of the links doesn't work at all, or just that neither link is 301-ing to the other?

Both links work, no 301-ing takes place.

This comes back to the query_Var being set to category_name rather than 'cat' as you'd expect in this case.

The solution would be to change that var, however, I'm pretty sure we'll then also run into the fact that the rewrite rules are also based on that query variable.

dd32 — what do rewrite rules matter? This is for default permalinks — no rewrite rules are in play.

We need to move back to cat=. category_name= should still work and should probably canonically redirect.

Replying to nacin:

We need to move back to cat=. category_name= should still work and should probably canonically redirect.

Oops I thought ?cat= should redirect to ?category_name=

Replying to markjaquith:

dd32 — what do rewrite rules matter? This is for default permalinks — no rewrite rules are in play.

I was attempting to make the point of why the change has happened, That it's using the query_var specified in the register_taxonomy call, of whcih, is also utilised by the rewrite rule generation code, when you also look at the get_term_link code, it either uses the permastruct in use, or the query_var, Ie. The generated rewrite rules, as well as the non-rewrite rules rely on the same query var param

get_term_link either needs a specific branch for categories in the non-rewrite context to use cat + id rather than category_name + slug (as all other taxonomy non-rewrite rules are)

get_term_link modification for ?cat=

attachment 16644.2.diff added

• modifies get_term_link to return ?cat= links.

attachment 16644.3.diff added

extended dd32's patch for canonical redirects

Per bug scrub, 16644.2.diff is the direction we want to go. We don't want to change canonical in a dot release. Let's test .2 and get it in.

I tested 16644.2.diff on a couple trunk installs and it works for me

greuben — can you open a ticket with category_name canonical redirect against future release? Just don't want that in 3.1.1

16644.2.diff is good. Going in.

(In [17494]) Revert to the cat=X permalinks from 3.0 and earlier. props dd32. fixes #16644 for trunk

(In [17495]) Revert to the cat=X permalinks from 3.0 and earlier. props dd32. fixes #16644 for 3.1

Replying to markjaquith:

greuben — can you open a ticket with category_name canonical redirect against future release? Just don't want that in 3.1.1

#16728

?cat= doesn't include children after all, so get_term_link() will return URLs with different results, based on wether permalinks are turned on or not.

However:

(12:34:42 AM) rboren: That should return it whatever 3.0 did, yes? I don't care what it does as long it is what 3.0 does. :-)
(12:35:16 AM) rboren: I need a drink to talk about taxonomy.

Alas, I don't have enough whiskey to make that change. :)