Opened 2 years ago

Last modified 7 months ago

#16707 reopened defect (bug)

No theme is one theme

Reported by: cogmios Owned by:
Priority: normal Milestone: Awaiting Review
Component: Themes Version: 3.1
Severity: minor Keywords: has-patch needs-testing 2nd-opinion
Cc: ldebrouwer, mdhansen@…

Description

If you have no themes at all it still says:

"You only have one theme installed right now. Live a little!"

Attachments (3)

themes-patch.diff (1.7 KB) - added by ldebrouwer 2 years ago.
Diff file to patch the bug
16707.2.diff (1.7 KB) - added by MikeHansenMe 7 months ago.
simpler patch with wording from original patch.
current-theme.png (17.8 KB) - added by MikeHansenMe 7 months ago.
current theme section, after removing all themes from directory.

Download all attachments as: .zip

Change History (11)

Diff file to patch the bug

  • Cc ldebrouwer added
  • Keywords has-patch needs-testing added; needs-patch removed
  • Resolution set to fixed
  • Status changed from new to closed

The diff file attached above checks whether a theme is installed. If not it displays a message prompting the user to install one. It also displays a friendly message when the current theme has been removed or misplaced but alternate themes are available so the user know he/she has to switch to a working theme.

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hey Luc, tickets are closed as fixed once the patch is committed.

Ok thanks, sorry for the n00b action in that case :)

Given that the whole of Wordpress falls over when there are no themes, wouldn't it be better to put that notice say on the dashboard instead of in themes.php?

I guess so but that doesn't take away the fact that it should be stated on the themes page as well.

simpler patch with wording from original patch.

  • Cc mdhansen@… added
  • Keywords 2nd-opinion added

added a new patch to accomplish the same as the original patch. This raised a question for me while viewing the themes page after the theme directory had been removed.

Should we remove the "Current Theme" section when no themes exist? (I think so)

current theme section, after removing all themes from directory.

  • Component changed from UI to Themes
Note: See TracTickets for help on using tickets.