WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 8 months ago

#16719 new defect (bug)

Remove vestige add_users capability

Reported by: nacin Owned by:
Priority: normal Milestone: Future Release
Component: Role/Capability Version:
Severity: normal Keywords: 3.2-early has-patch
Cc:

Description

Listed in populate_roles_300() and added in [14174], it was never used. The situation it was presumably introduced for now falls on promote_users.

Attachments (1)

patch16719.diff​ (483 bytes) - added by renoirb 2 years ago.
Remove legacy hook as per proposed

Download all attachments as: .zip

Change History (6)

renoirb — 2 years ago

Remove legacy hook as per proposed

comment:1 nacin — 12 months ago

  • Keywords has-patch added
  • Milestone changed from Future Release to 3.5

Wondering whether we should go through the trouble of also removing it in an upgrade routine.

comment:2 markjaquith — 12 months ago

Four plugins in the repo are using it. Should we yank the actual cap and then map it to promote_users? Either way, I'm thinking that the actual cap should be removed from any roles that have it.

comment:3 nacin — 12 months ago

Either way, I'm thinking that the actual cap should be removed from any roles that have it.

Seems fine to me. We can use map_meta_cap to map it to promote_users. Opens us up to adding it in the future.

comment:4 nacin — 8 months ago

In [22300]:

Comment that the add_users capability was never used and has its days numbered. see #16719.

comment:5 nacin — 8 months ago

  • Milestone changed from 3.5 to Future Release

Per scrub.

Note: See TracTickets for help on using tickets.