[16918] Broke PATHINFO custom taxomony permalinks

[markjaquith]

[16918] fixed #15813 for built in taxonomies, but broke it for custom taxonomies. It now double-adds the index.php/ prefix to the rewrite rules.

index.php/index.php/type/([^/]+)/?$ => index.php?post_format=$matches[1]

Looks like patch on #16662 fixes this (along with revert of [16918])

Replying to duck_:

Looks like patch on #16662 fixes this (along with revert of [16918])

Unless you change the category base:

'topics/(.+?)/?$' => 'index.php?category_name=$matches[1]',

Replying to duck_:

Looks like patch on #16662 fixes this (along with revert of [16918])

Obviously I'm completely failing to notice that this is only papering over the issue that with_front false doesn't work with PATHINFO permalinks (the same is true of custom post types registered with with_front => false).

/me hopes I don't quadruple post

My research has yielded these results. There's more to it. Regular category permalinks were broken too.

Structure = /archives/%postname%

3.0.5

• ​http://wp.dev/archives/people/mark-jaquith (works)
• ​http://wp.dev/archives/category/uncategorized (works)

3.1

• ​http://wp.dev/archives/people/mark-jaquith (works)
• ​http://wp.dev/archives/category/uncategorized (404)
• ​http://wp.dev/category/uncategorized (works, but it is a different URL!)

Structure = /index.php/archives/%postname%

3.0.5

• ​http://wp.dev/index.php/archives/people/mark-jaquith (works)
• ​http://wp.dev/index.php/archives/category/uncategorized (works)

3.1

• ​http://wp.dev/index.php/archives/people/mark-jaquith (404)
• ​http://wp.dev/index.php/archives/category/uncategorized (404)
• ​http://wp.dev/index.php/category/uncategorized (works, but it is a different URL!)

Structure = /%year%/%monthnum%/%postname%

3.0.5

• ​http://wp.dev/people/mark-jaquith (works)
• ​http://wp.dev/category/uncategorized (works)

3.1

• ​http://wp.dev/people/mark-jaquith (works)
• ​http://wp.dev/category/uncategorized (works)

Structure /index.php/%year%/%monthnum%/%postname%

3.0.5

• ​http://wp.dev/index.php/people/mark-jaquith (works)
• ​http://wp.dev/index.php/category/uncategorized (works)

3.1

• ​http://wp.dev/index.php/people/mark-jaquith (404)
• ​http://wp.dev/index.php/index.php/people/mark-jaquith (works, but it is a different URL!)
• ​http://wp.dev/index.php/category/uncategorized (works)

My research has yielded these results. There's more to it. Regular category permalinks were broken too.

Different Changeset there.. That'll be [15825], Setting with_front => true in the category tax registration should fix that

Replying to dd32:

My research has yielded these results. There's more to it. Regular category permalinks were broken too.

Different Changeset there.. That'll be [15825], Setting with_front => true in the category tax registration should fix that

Yes, with_front solves it. I've already attached a patch on ticket:16662:16662.3.diff​

Prevent double index.php preprend on PATHINFO custom taxonomy permalinks. Proper use of with_front. props greuben. fixes #16918. fixes #16622. see #15813. see #12659. For trunk

Prevent double index.php preprend on PATHINFO custom taxonomy permalinks. Proper use of with_front. props greuben. fixes #16773. fixes #16662. see #15813. see #12659. For 3.1