uninstall_plugins is autoloaded

[duck_]

The uninstall_plugins option is autoloaded despite documentation suggesting otherwise. This has been the case since it was introduced, see #5625 and [8585].

Example patch attached. Or it could be left as autoloaded and comments removed.

No wonder why class method callbacks slowed sites down as much as they did.

We can just add this to $fat_options and handle the switch in an upgrade path.

Replying to nacin:

No wonder why class method callbacks slowed sites down as much as they did.

We can just add this to $fat_options and handle the switch in an upgrade path.

16741.upgrade.diff: semi-done (no db_version bump or call to upgrade path).

The difference would be that uninstall_plugins would become a default option instead of added when necessary. If that's undesired then a mixture of the two can be taken. Have an upgrade path for existing installs and set autoload to 'no' on the first registration so it's not a default option.

Nice catch.

I don't see a problem with it becoming a default option, since it isn't autoloaded.

Upgrade path should probably be get, delete, add, rather than a direct query. No issues with it being a default option.

Refreshed for 3.4. I realized since populate_options() gets called before upgrade_*(), the option will always exist by the time we try to call get_option(), so a direct query to ascertain its autoload property seems like the best route.

In [20080]:

Don't autoload the uninstall_plugins option. fixes #16741.

Note that now plugin authors will have to wrap register_uninstall_hook() in an is_admin() check, to avoid an extra query.

Hmm. Perhaps we should just noop register_uninstall_hook() when we're not in the admin.

As it is, register_uninstall_hook() should only be occurring on an activation hook.

Hmm. Perhaps we should just noop register_uninstall_hook() when we're not in the admin.

My thoughts exactly.

register_uninstall_hook() should only be called on activation. If they discover that it is generating an extra query (on the frontend), then they are doing it wrong.