Opened 2 years ago

Last modified 2 years ago

#16745 new enhancement

doubled replace in setup_postdata

Reported by: hakre Owned by:
Priority: normal Milestone: Awaiting Review
Component: General Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Attachments (4)

16745.patch (603 bytes) - added by hakre 2 years ago.
One off
16745.2.patch (749 bytes) - added by hakre 2 years ago.
Array'ed
16745.3.patch (1.4 KB) - added by hakre 2 years ago.
The "while we're at it" stop-by
16745.4.patch (1.4 KB) - added by hakre 2 years ago.
Same as prev but with #16746 fix

Download all attachments as: .zip

Change History (8)

hakre2 years ago

One off

hakre2 years ago

Array'ed

hakre2 years ago

The "while we're at it" stop-by

  • Type changed from defect (bug) to enhancement

hakre2 years ago

Same as prev but with #16746 fix

In case of fixing #16745, another patch has been attached as .3 would conflict merge with the fix in #16745.

Version 0, edited 2 years ago by hakre (next)

comment:3 follow-up: ↓ 4   garyc402 years ago

I'm sorry, but, what?

Could you write a better description for this ticket? And what do your patches have anything to do with the URL you posted?

comment:4 in reply to: ↑ 3   hakre2 years ago

Replying to garyc40:

I'm sorry, but, what?

Could you write a better description for this ticket?

The patches are rather trivial so I thought self explanatory:

If you first replace BA with A and then replace AB with A then there is no need to replace BAB with A as a third replace variant upfront.

Next to that, you can make use of arrays to replace multiple needles at once.

And what do your patches have anything to do with the URL you posted?

The URL was just informative, if you visit that address you will see the sourcecode of function setup_postdata() this ticket is about.

Note: See TracTickets for help on using tickets.