Opened 2 years ago

Last modified 19 months ago

#16754 new enhancement

PHP5-port - srand()

Reported by: hakre Owned by:
Priority: normal Milestone: Awaiting Review
Component: General Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Description

No need to seed the random number generator.

See ​srand() for details.

Related: #16753

Attachments (2)

16754.patch​ (447 bytes) - added by hakre 2 years ago.
Probably this just was forgotten
18999.diff​ (1.2 KB) - added by crrobi01 19 months ago.

Download all attachments as: .zip

Change History (5)

hakre — 2 years ago

Probably this just was forgotten

comment:1   nacin — 2 years ago

  • Type changed from defect (bug) to enhancement

crrobi01 — 19 months ago

comment:2   crrobi01 — 19 months ago

  • Version changed from 3.1 to 3.3
  • Removed srand()
  • There's no reason to do floor(rand()) when rand() always returns an integer.
  • Renamed $emailNOSPAMaddy to $email_no_spam_addy to match ​Coding Standards
  • Replaced "$i = $i + 1" with "$i++" which is more common in WordPress

comment:3   SergeyBiryukov — 19 months ago

  • Version changed from 3.3 to 3.1

Version field indicates when the enhancement was initially suggested.

Note: See TracTickets for help on using tickets.