Bulk inline post edit doesn't show categories or tags if the CPT doesn't support titles

[scribu]

1. Register a CPT that doesn't support titles:

add_action( 'init', function() {
	register_post_type( 'foo', array(
		'show_ui' => true,
		'label' => 'Foo',
		'supports' => array( 'editor' ),
		'taxonomies' => array( 'category', 'post_tag' )
	) );
} );

2. Create a 'foo' post.

3. Go to wp-admin/edit.php?post_type=foo and choose the 'Edit' bulk action.

Expected behaviour: shows the category checkbox list and the tag textarea.

Actual behaviour: only the status dropdown is shown.

I found it worked before, and after Scribu; unless I'm holding it wrong?

If you're using Chrome, without the patch, you should also be getting a JS error in the console:

Uncaught TypeError: Cannot read property 'firstChild' of null

Note that we're talking about the Edit option in the dropdown, not the quick action Edit link on each post.

OK so I was holding it wrong, I can confirm the initial error, and that the patch works! :)

optimize selectors

(In [17504]) Don't perform taxonomy queries for single post requests. Props scribu. fixes #16793 for trunk

selector cleanup + DRY

16793.3.diff​:

Contrary to popular belief, $('some selector', context) is not faster than context.find('some selector'). It's just harder to read.

Also, there was a callback written twice, once for qeRow.keyup and again for bulkRow.keyup.

another casualty of this problem is that any javascript (and jQuery) that would be executed on the wp-admin/edit.php?post_type=foo screen can't run, as the javascript engine stops at that initial Uncaught TypeError: Cannot read property 'firstChild' of null error. I had been adding some additional sorting options via jQuery, and couldn't figure out why they appeared on some post type edit lists, but not this one, until I found this ticket...

I can confirm that adding the supports => titles does fix the problem, but it's not absolute: I have two CPT, registered with basically identical args, and neither supports titles - but one manifests the javascript error on edit.php and the other does not...