Ticket #1683 (closed defect (bug): fixed)

Opened 6 years ago

Last modified 5 years ago

Blogger Importer inserts comments directly

Reported by: skeltoac Owned by: ryan
Priority: high Milestone:
Component: Administration Version: 1.6
Severity: normal Keywords: importer
Cc:

Description

One last MySQL query. To speed importing and ensure the script doesn't die() on inserting comments, this diff adds circumvention of checks in wp_new_comment().

Attachments

1683.diff Download (5.6 KB) - added by skeltoac 6 years ago.
svn diff
1683.2.diff Download (21.9 KB) - added by skeltoac 6 years ago.
svn diff

Change History

svn diff

comment:1   ryan6 years ago

Actually, I'd like to bust this up into multiple functions.

wp_insert_comment() would handle the DB insertion.

wp_allow_comment() would do the flood protection, check_comment(), wp_blacklist_check(), and other checks.

wp_new_comment_notification() would live in pluggable-functions and would call wp_notify_post_author() and wp_notify_moderator.

wp_new_comment() would wrap all of these up into one call.

Importers would call wp_insert_comment() and thus avoid the comment checks and mail notifications.

wp_new_comment() would continue to be used as is.

svn diff

Done.

comment:3   ryan6 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [2894]) wp_insert_comment(), wp_update_comment(), wp_allow_comment(), and wp_filter_comment() from skeltoac. fixes #1683

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.