Opened 2 years ago

Closed 8 months ago

#16852 closed enhancement (fixed)

Don't output redundant dir="ltr" with language_attributes()

Reported by: bergius Owned by: nacin
Priority: normal Milestone: 3.5
Component: RTL Version: 3.1
Severity: trivial Keywords: has-patch commit
Cc: linuxologos@…

Description

language_attributes() outputs dir="ltr" when is_rtl() returns false, but declaring the text direction as left-to-right is redundant.

Patch only outputs the dir attribute when the direction is right-to-left.

Attachments (3)

16852.diff​ (581 bytes) - added by bergius 2 years ago.
16852_2.diff​ (579 bytes) - added by bergius 2 years ago.
Tabs, not spaces.
16852_3.diff​ (548 bytes) - added by ramiy 18 months ago.

Download all attachments as: .zip

Change History (9)

bergius — 2 years ago

comment:1   scribu — 2 years ago

  • Summary changed from [PATCH] Don't output redundant dir="ltr" with language_attributes() to Don't output redundant dir="ltr" with language_attributes()

Please use tabs, not spaces: ​http://codex.wordpress.org/WordPress_Coding_Standards

bergius — 2 years ago

Tabs, not spaces.

comment:2   linuxologos — 2 years ago

  • Cc linuxologos@… added

comment:3   ramiy — 19 months ago

bergius, i think you can remove - function_exists( 'is_rtl' ) .

ramiy — 18 months ago

comment:4   nacin — 8 months ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 3.5

I think the function_exists is still needed. See [14360].

comment:5   nacin — 8 months ago

  • Keywords commit added; needs-refresh removed

16852_2.diff​ is good.

comment:6   nacin — 8 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [21904]:

Stop outputting the default dir="ltr" in language_attributes(). props bergius. fixes #16852.

Note: See TracTickets for help on using tickets.