Opened 2 years ago

Last modified 19 months ago

#16876 new enhancement

Separate msgid "Post" from wp-includes/post.php:1154 for the administration menu and custom menu creation screen

Reported by: waclawjacek Owned by:
Priority: normal Milestone: Future Release
Component: I18N Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Description

Hey! It seems that both the custom menu creation screen and the administration menu bar are using the same translation. Could you please separate them? Here's the relevant bit of tags/3.1/wordpress.pot:

 2700 #: wp-includes/post.php:1154
 2701 msgctxt "post type singular name"
 2702 msgid "Post"
 2703 msgstr ""
 2704 
 2705 #: wp-includes/post.php:1154
 2706 msgctxt "post type singular name"
 2707 msgid "Page"
 2708 msgstr ""

Cheers!
WJ

Attachments (1)

16876.patch (3.1 KB) - added by SergeyBiryukov 23 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 follow-up: ↓ 2   SergeyBiryukov23 months ago

  • Keywords reporter-feedback added

The only solution I see is to add another key to get_post_type_labels().

What are we trying to fix here? Do post type labels in Polish need a separate context for the Menus screen?

comment:2 in reply to: ↑ 1   waclawjacek23 months ago

Replying to SergeyBiryukov:

What are we trying to fix here? Do post type labels in Polish need a separate context for the Menus screen?

Yes, this is exactly the problem.

The only solution I see is to add another key to get_post_type_labels().

Another solution would probably be to simply change either of the contexts to something else, so the strings don't get merged into one in .pot files.

Thanks,
Wacław

comment:3 follow-up: ↓ 4   SergeyBiryukov23 months ago

  • Keywords has-patch added; reporter-feedback removed

get_post_type_labels() is where all the post type label contexts are listed.

For consistency, I've added menu item type context to taxonomies as well.

comment:4 in reply to: ↑ 3   waclawjacek22 months ago

Replying to SergeyBiryukov:

get_post_type_labels() is where all the post type label contexts are listed.

For consistency, I've added menu item type context to taxonomies as well.

Sounds good! Thanks! :)

  • Milestone changed from Awaiting Review to 3.3

comment:6 follow-up: ↓ 7   ryan19 months ago

  • Milestone changed from 3.3 to Future Release

The label proliferation is getting out of hand. Let's punt this to 3.4 and see if we can come up with alternatives.

comment:7 in reply to: ↑ 6   nacin19 months ago

Replying to ryan:

The label proliferation is getting out of hand. Let's punt this to 3.4 and see if we can come up with alternatives.

Agreed.

Note: See TracTickets for help on using tickets.