Opened 2 years ago

Last modified 2 years ago

#16909 new defect

some Location headers are using relative url's (2)

Reported by: hakre Owned by:
Priority: normal Milestone: Awaiting Review
Component: General Version: 3.1
Severity: normal Keywords:
Cc: WordPress@…

Description

I started this in #14062 and already did some fixes for 3.1.

Just collecting some more and providing patches.

Attachments (5)

16909.patch (9.9 KB) - added by hakre 2 years ago.
Some leftover
16909.2.patch (841 bytes) - added by hakre 2 years ago.
those two
16909.3.patch (635 bytes) - added by hakre 2 years ago.
referer field
16909.4.patch (1012 bytes) - added by hakre 2 years ago.
Triggered by logout of the admin bar on frontend
16909.5.patch (545 bytes) - added by hakre 2 years ago.
Triggered by dashboard.php

Download all attachments as: .zip

Change History (14)

hakre2 years ago

Some leftover

Fix strategy: admin_url -> self_admin_url as we did in first round as well.

  • Cc WordPress@… added

comment:3   dd322 years ago

  • Keywords has-patch removed

admin_url will return a absolute URL. self_admin_url() is only needed for pages accessible from both the Network admin (or users admin) as well as the normal admin.

Replying to dd32:

admin_url will return a absolute URL. self_admin_url() is only needed for pages
accessible from both the Network admin (or users admin) as well as the normal
admin.

Ah, okay. Had not thought about that, the first patch was mainly a regex search, so I assume most of it does not apply any longer.

what about /wp-admin/network/edit.php and /wp-amin/user/admin.php? Is it the same?

hakre2 years ago

those two

hakre2 years ago

referer field

Found it via the options page. A _wp_http_referer is placed in there and later used in options.php to redirect to (/wp-admin/options.php:161). It was no full absolute location.

hakre2 years ago

Triggered by logout of the admin bar on frontend

Better HTTP Redirects now supports WB_DEBUG and displays extensive information about the redirect.

Related: #16907

/wp-admin/includes/dashboard.php:127 creates a redirect w/o an absolute URI.

hakre2 years ago

Triggered by dashboard.php

\wp-admin\user-new.php:100 , Related: #17018

Version 0, edited 2 years ago by hakre (next)
Note: See TracTickets for help on using tickets.