Opened 2 years ago
Closed 2 years ago
#16912 closed defect (bug) (fixed)
Quick edit error message styling lost in 3.1
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.2 |
| Component: | Editor | Version: | 3.1 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
In WP 3.0, quick edit error messages for posts (e.g., if someone else has lock on a post, and you try to save a quick edit) were put in a red box with a light red background.
In 3.1 this styling has been lost. The error just appears as normal text.
The change occurred in [16205].
Attachments (2)
Change History (9)
solarissmoke — 2 years ago
comment:2
solarissmoke — 2 years ago
- Keywords has-patch added; needs-patch removed
Screenshot 3.1: http://grab.by/9Cho
Screenshot 3.0: http://grab.by/9ChE
comment:5
johnjamesjacoby — 2 years ago
Tested. Patch applies clean. The style is not particularly as beautiful as the rest of the UI, but does get the point across.
@scribu trying to figure out why the global .error and .updated CSS classes were limited to DIVs only in [16205]. There is no mention about it in the ticket or the commit message. This looks like a regression and removing the limitation doesn't seem to affect anything in the admin.
Patch makes the error message handling consistent with inline edit elsewhere (comments, link categories etc all do it this way, with a hidden error span element). Also adds color:red. There also used to be a light red background but I'm not sure that is necessary..
Incidentally this will also fix #14317.