WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 18 months ago

#16935 new feature request

Wrap selected text in <blockquote> in press-this.php

Reported by: topdownjimmy Owned by:
Priority: normal Milestone: Awaiting Review
Component: Press This Version: 3.1
Severity: normal Keywords: has-patch 2nd-opinion needs-testing
Cc: info@…

Description

When using the "Press This" bookmarklet, any text selected on the current page is inserted into the post body textarea. This should be wrapped in a <blockquote> tag with some appropriate class name.

Attachments (3)

press_this_blockquote.diff (774 bytes) - added by ldebrouwer 2 years ago.
Added blockquotes to the "Press This" content.
press_this_blockquote_2.diff (808 bytes) - added by topdownjimmy 2 years ago.
Added blockquote with "press-this-selection" class
press_this_blockquote_3.diff (832 bytes) - added by topdownjimmy 2 years ago.
Previous patch fixed to include single quotes instead of double quotes on class name

Download all attachments as: .zip

Change History (9)

ldebrouwer2 years ago

Added blockquotes to the "Press This" content.

comment:1 ldebrouwer2 years ago

  • Cc info@… added
  • Keywords has-patch needs-testing dev-feedback 2nd-opinion added

I didn't add a class, I did add the cite attribute. However this still needs an okay from higher up for the feature request to be honored. I can see the 'need' for this because why would anybody want to copy content from a different website without a <blockquote>, unless they're stealing content ;)

comment:2 topdownjimmy2 years ago

Would "press-this-selection" be an appropriate class name?

topdownjimmy2 years ago

Added blockquote with "press-this-selection" class

comment:3 topdownjimmy2 years ago

Just added another patch including your changes plus the class "press-this-selection"

This is my first time contributing a patch so I hope I've done it correctly.

comment:4 topdownjimmy2 years ago

Ha, already screwed that up. I used double quotes where I should have used single quotes. New patch corrected and uploaded. Apologies.

topdownjimmy2 years ago

Previous patch fixed to include single quotes instead of double quotes on class name

comment:5 ocean9023 months ago

  • Component changed from General to Press This
  • Keywords dev-feedback removed

Related: #16935

comment:6 jane18 months ago

For the record, I would love selected area to automatically get blockquoted.

Note: See TracTickets for help on using tickets.