Opened 2 years ago

Closed 7 months ago

Last modified 7 months ago

#16937 closed enhancement (invalid)

make_site_theme_from_default() refactoring

Reported by: hakre Owned by:
Priority: normal Milestone:
Component: General Version: 3.0.5
Severity: normal Keywords: has-patch close
Cc:

Description

just some little refactoring, partly because of new functions available with PHP 5.0.0, but prior to put the duplicated code into a function of it's own.

Related: #16917, #16920

Attachments (2)

16937.patch​ (3.2 KB) - added by hakre 2 years ago.
16937.patch
16937.2.patch​ (3.3 KB) - added by hakre 2 years ago.
Fix: was else-if structure, foreach construct more readable

Download all attachments as: .zip

Change History (7)

comment:1   hakre — 2 years ago

  • Keywords has-patch added
  • Version set to 3.0.5

hakre — 2 years ago

16937.patch

hakre — 2 years ago

Fix: was else-if structure, foreach construct more readable

comment:2   hakre — 2 years ago

  • Type changed from defect to enhancement

comment:4   MikeHansenMe — 7 months ago

  • Resolution set to invalid
  • Status changed from new to closed

It seems this code is only used for 1.3 -> 1.5 upgrades. This code should not be updated and should eventually be removed.

comment:5   helenyhou — 7 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.