Opened 2 years ago

Last modified 2 years ago

#16943 new enhancement

Code Cleanup add_query_arg() + friends

Reported by: hakre Owned by:
Priority: normal Milestone: Awaiting Review
Component: General Version: 3.1
Severity: normal Keywords: has-patch needs-unit-tests
Cc:

Description

This should reduce the complexity of add_query_arg() a bit.

This is partially related to PHP 5 stuff (#16918,#16920) we can make use of now.

Originated in #16932

Related: #16942

Attachments (1)

16943.patch​ (5.8 KB) - added by hakre 2 years ago.
add_query_arg() + friends

Download all attachments as: .zip

Change History (5)

hakre — 2 years ago

add_query_arg() + friends

comment:1   hakre — 2 years ago

Tested and Benchmarked. Looks good from my point of view for a first patch.

comment:2   dd32 — 2 years ago

Could we get some unit tests for those changes?

comment:3   dd32 — 2 years ago

  • Keywords needs-unit-tests added

comment:4   hakre — 2 years ago

You can find some functional tests here: ​https://gist.github.com/882734

Note: See TracTickets for help on using tickets.