#17131 closed enhancement (fixed)
Make theme's content_width available in XML-RPC
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.2 |
| Component: | XML-RPC | Version: | |
| Severity: | normal | Keywords: | mobile revert |
| Cc: | ercoli@…, westi |
Description
To upload properly sized images, being able to access the theme's $content_width variable from XML-RPC would help
Attachments (1)
Change History (11)
comment:1
nacin
— 2 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 3.2
comment:3
daniloercoli
— 2 years ago
- Cc ercoli@… added
comment:4
josephscott
— 2 years ago
- Resolution set to fixed
- Status changed from new to closed
comment:5
westi
— 2 years ago
- Cc westi added
- Resolution fixed deleted
- Status changed from closed to reopened
As I said in IRC when this was originally being discussed.
I'm not sure why the theme's content width matters during image upload - what happens when I switch to a wider theme later?
Should the app not be working the media settings which have already been exposed?
comment:6
ptahdunbar
— 2 years ago
We should standardize accessing the $content_width var instead of doing it manually everywhere. Enter, get_content_width() - #17130
comment:7
nacin
— 2 years ago
- Keywords revert added; has-patch removed
Agreed on revert. I offered the patch before considering its usage. I was in IRC with westi and agreed then.
comment:9
ryan
— 2 years ago
- Owner set to ryan
- Resolution set to fixed
- Status changed from reopened to closed
In [18119]:
comment:10
ramiy
— 11 months ago
Related: #21256
Note: See
TracTickets for help on using
tickets.
Patch also needs to check if $content_width isn't set and return 0. Probably also needs an int cast.