Image-error in Multisite (subdir)

[dvwallin]

When setting up a multisite-network using subdirectory-method in Wordpress 3.1.x images get the wrong encoding and doesn't show up anywhere.

This is due to the header-setting being wrong in ms-files.php where, to solve the issue, you simply replace

header( 'Content-type: ' . $mimetype ); always send this

with

header("Content-Type: $mimetype"); always send this

Those two lines of code are equivalent. The resulting string that's sent to the header() function is the same.

To test:

var_dump( 'Content-type: ' . $mimetype );

var_dump( "Content-Type: $mimetype" );

I know but for some reason the later one worked and the first one did not.

No, something else has to be going on. Maybe you're testing different URLs.

Not at all. Been quite detailed in the tests. Changing that single line made the image-handling work throughout the multisite-setup. But i wont push for the patch. I'm using it and it works for me.

The difference isn't in the concatenation method, it's the capitalisation of 'Type'.

I couldn't reproduce the issue, but some searching does suggest that some badly written applications may expect Content-Type only.

Ha, I knew it was something else. Thanks, kawauso.

We use Content-Type everywhere else, might as well be consistent.

In [17922]:

s/Content-type/Content-Type/. Props dvwallin. fixes #17256