wp_get_attachment_thumb_file is always false

[lonnylot]

The issue is that on line 3863 we always search for $imagedata['thumb'] and it never exists. Instead we have $imagedata['thumbnail']. This always exists.

Please submit patches as svn diffs. Tutorials can be found on the trac homepage.

wp-includes/post.php diff

Sorry for the delay! Added the correct diff off of trunk rev. 18191

So does wp_get_attachment_thumb_file() ever work? That function should probably be deprecated in favor of the various other functions now.

As far as I can tell not unless you add a custom image type called 'thumb'

@nacin is right, deprecate +1.

[attachment:17262.2.diff​​] updates wp_get_attachment_thumb_file() so it works in trunk. The previous patch did not have current code in mind. It's not immediately obvious to me what wp_get_attachment_thumb_file() and wp_get_attachment_thumb_url() would be deprecated in favor of.

'thumb' is the old-style thumbnail, prior to proper intermediate sizes ('thumbnail' / 'medium' / 'large').

wp_get_attachment_thumb_url() does return the newer 'thumbnail' if it exists, and falls back to wp_get_attachment_thumb_file() if it does not.

You can see a bit of code history in image_downsize(): "fall back to the old thumbnail" in a code comment.

Not sure what _file() should return in a deprecated situation. _url() is basically the old-school form of wp_get_attachment_image_src( $size = 'thumbnail' ), which returns array( $src, $width, $height ). Which is kind of lame.

So, perhaps they can both be updated to work on 'thumbnail', and then left, as wp_get_attachment_thumb_url() is definitely easier, nicer, and more obvious to use than wp_get_attachment_image_src()['url'], and according to MarkJaquith, is widely used by plugins (probably for that reason).

#23556 was marked as a duplicate.

This one first checks for the "fall back to the old thumbnail" and if that returns false then goes ahead and checks according to the revised array

#10492 was marked as a duplicate.