Ticket #17324 (closed task (blessed): fixed)
UI Style Update
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.2 |
| Component: | UI | Version: | 3.1 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | ocean90, andrewryno@…, sararcannon@…, mikeschinkel@…, matt@…, pascal.herbert@…, dre@…, toby.mckes@…, willmot, yoavf |
Description
Per discussion and comps on make.wordpress.org/ui, going for a little style refresh in 3.2.
Attachments
Change History
comment:1
koopersmith — 10 months ago
First pass for the new styles. Nav menus, widgets, and list tables need love. So do down arrows. And the blue theme, which looks... a little wonky right now.
comment:2
koopersmith — 10 months ago
- Keywords has-patch added; needs-patch removed
- Owner set to koopersmith
- Status changed from new to accepted
comment:3
koopersmith — 10 months ago
These images should be added to/modified in wp-admin/images.
comment:5
markjaquith — 10 months ago
In [17800]:
comment:6
markjaquith — 10 months ago
In [17801]:
comment:8
markjaquith — 10 months ago
- The "gutter" horizontal rule in the menus needs work.
- We need a "collapse menu" thing like in the comp
- Theme inactive tab needs more contrast
Keep working on this ticket. Nice work, Koop!
comment:10
follow-up:
↓ 11
markjaquith — 10 months ago
comment:11
in reply to:
↑ 10
jane — 10 months ago
Replying to markjaquith:
"Configure" link overlaps. And the arrow seems too far to the left.
I thought we were going to get rid of the open/close function. That would lose the arrows.
comment:12
andrewryno — 10 months ago
Few notes. Just minor stuff for now.
- Arrows for toggling menu items and postboxes don't change cursor to show it's clickable (menu one looks on purpose, what's the reasoning on not showing it's clickable)? -- I can do a quick patch, just wanted to know why it was done on purpose.
- Arrow on post box is aligned weird (too far to left or close to the border)? Just saw Mark posted this as well
- Favorites menu uses div's inside the h2 making the dashboard invalid HTML.
- When the menu is collapsed and subpages displayed in the flyout, no border/background/shadow to differentiate from rest of the page. Simple examples: http://d.pr/2SZB or http://d.pr/y6L2
I'm going to do more testing on different browsers in a bit for some extra tests.
comment:13
follow-up:
↓ 20
andrewryno — 10 months ago
Widget styling needs fixing. Widget titles are changed to the new style but the holder still uses the old postbox style. http://d.pr/xRNR
Edit: Also inactive widgets need fixing http://d.pr/WoBu
I'll do patches for these if someone doesn't get to them first.
comment:14
scribu — 10 months ago
comment:15
follow-up:
↓ 21
scribu — 10 months ago
comment:16
ryan — 10 months ago
The long-title class when applied to siteheading mucks up the header a bit. Test with a long site name.
comment:17
ryan — 10 months ago
There's no separator between Settings and the first top-level menu added by plugins.
comment:18
jane — 10 months ago
Just a reminder to contributors that this patch went in without being "finished," so it might be worth waiting a day for Daryl to finish getting things put in before listing small details. We went with the broad stroke for v1 to get it up there so people could see progress, but have a whole bunch of stuff to finish up before we start debating details.
comment:19
jane — 10 months ago
I made a thread on UI blog for people to make UI suggestions, ask questions, debate colors, positioning, size, etc. related to this ticket. This way, we can keep the ticket relatively clean for tasks that need to be completed that have been approved by leads, and/or for reporting bugs with the new code. Thanks.
comment:20
in reply to:
↑ 13
jane — 10 months ago
Replying to andrewryno:
Widget styling needs fixing. Widget titles are changed to the new style but the holder still uses the old postbox style. http://d.pr/xRNR
Edit: Also inactive widgets need fixing http://d.pr/WoBu
I'll do patches for these if someone doesn't get to them first.
Daryl is still working on getting all the styling in. Wait a day and see what needs doing. First version went in incomplete on purpose to get basic layout in.
comment:21
in reply to:
↑ 15
mikeschinkel — 10 months ago
- Cc mikeschinkel@… added
Replying to scribu:
Submenus with the same name look very redundant now:
Would there be any support for the core team for a way to disable the redundant submenu page link via a hook?
comment:22
follow-up:
↓ 23
dd32 — 10 months ago
Would there be any support for the core team for a way to disable the redundant submenu page link via a hook?
Lets get the UI refresh finalised before getting into adding hooks for things
comment:23
in reply to:
↑ 22
mikeschinkel — 10 months ago
Replying to dd32:
Would there be any support for the core team for a way to disable the redundant submenu page link via a hook?
Lets get the UI refresh finalised before getting into adding hooks for things
I asked the question to determine if it was worth the effort to submit another ticket for a hook; an opinion that it might be considered would not block UI refreshing in any way that I can see. A simple "yes", "no" or even "maybe" would suffice.
comment:24
saracannon — 10 months ago
I've been following along with Daryl's changes and applying the changes to the Blue Admin. (colors-classic.dev.css) I've attached a diff (blue_update.patch) of what I've modified so far. The colors-fresh.dev.css and the colors-classic.dev.css now match line-for line. There is still more tweaking to be done with colors/borders/menus/widgets. I will post up for a review on the blue changes on make.wordpress.org/ui after the grey is set in stone. So, as we go along, I'll be replacing the patch with modifications following daryl's modifications.
Screenshot: http://cl.ly/302k273J0e1l0l1B3v1k
comment:25
koopersmith — 10 months ago
In [17815]:
WraithKenny — 10 months ago
-
attachment
fix-footer.patch
added
Fixes sidebar background not reaching past footer when scrollbars are visible
comment:26
koopersmith — 10 months ago
In [17817]:
comment:27
mattwiebe — 10 months ago
- Cc matt@… added
Please, for the love, put Helvetica Neue before Arial in the base font stack. We're better than Arial-as-default.
body, td, textarea, input, select{
font-family: 'Helvetica Neue', Arial, 'Bitstream Vera Sans', Helvetica, Verdana, sans-serif;
}
comment:28
koopersmith — 10 months ago
In [17818]:
comment:32
markjaquith — 10 months ago
In [17820]:
comment:33
markjaquith — 10 months ago
comment:34
scribu — 10 months ago
Related: #17341
comment:35
follow-up:
↓ 38
tmtrademark — 10 months ago
- Cc toby.mckes@… added
Love it. Know this is still WIP, but the Collapse Menu button on the bottom isn't actually functional yet. Had to hunt for the correct spot in the thick grey separators.
comment:36
koopersmith — 10 months ago
In [17827]:
comment:37
koopersmith — 10 months ago
In [17828]:
comment:38
in reply to:
↑ 35
koopersmith — 10 months ago
Replying to tmtrademark:
...the Collapse Menu button on the bottom isn't actually functional yet. Had to hunt for the correct spot in the thick grey separators.
It was a caching issue—fixed in [17828].
comment:39
koopersmith — 10 months ago
In [17829]:
comment:40
koopersmith — 10 months ago
In [17833]:
comment:41
koopersmith — 10 months ago
In [17834]:
comment:42
markjaquith — 10 months ago
In [17835]:
comment:43
chexee — 10 months ago
The Plugins nav menu does't have the colored icon when active (only on hover).
Screenshot: http://cl.ly/0M1N310U1d062l3G1h2z
comment:44
markjaquith — 10 months ago
In [17839]:
comment:45
koopersmith — 10 months ago
In [17844]:
comment:46
ryan — 10 months ago
That's a very rough beginning toward moving what is now in the first h2 of each screen up into the h1. The blog name is now moved over under the Howdy. set_screen_attribute() allows setting the title, sub_title, icon class, and other bits for the current screen. Plugins can use this off of a load-* hook.
comment:47
follow-up:
↓ 56
Mamaduka — 10 months ago
This style updates looks great. But I think Contextual Help and Screen Options link wrappers don’t fit with new style, so I just changed few things to fit new style
Screenshot: http://i.imgur.com/lnnH8.jpg
comment:48
koopersmith — 10 months ago
In [17848]:
comment:49
ryan — 10 months ago
In [17849]:
comment:50
markjaquith — 10 months ago
In [17850]:
comment:51
koopersmith — 10 months ago
In [17851]:
-
attachment
17324.fixed-stuffbox-border-bg.diff
added
Updated the .stuffbox class with mouse nibbled borders and #f9f9f9 background.
comment:52
chexee — 10 months ago
The .stuffbox class was missing the corners and bg color. (Example of these boxes on the "Add New Link Page". 17324.fixed-stuffbox-border-bg.diff fixes that.
-
attachment
17324.plugin-icon.diff
added
Fixes active plugin icon. Was grey, should be colored on active.
comment:53
koopersmith — 10 months ago
In [17853]:
comment:54
koopersmith — 10 months ago
In [17854]:
comment:55
koopersmith — 10 months ago
In [17855]:
comment:56
in reply to:
↑ 47
STDestiny — 10 months ago
Regarding the Screen Options and Help dropdowns, it might be useful to add a "close" link to the top right of those sections. As it is now, you have to move the mouse quite a bit to close those sections, especially if the screen is very long.
comment:57
markjaquith — 10 months ago
In [17858]:
comment:58
koopersmith — 10 months ago
In [17859]:
comment:59
willmot — 10 months ago
- Cc willmot added
If the screen_icon size change is staying is the plan to change the screen_icon class to icon28 instead of icon32? That way plugins could provide icons for both 3.2 and pre 3.2. Or is that being accounted for some other way?
comment:60
markjaquith — 10 months ago
My hit list:
- Change the menu drop shadow to be a gradient, with black color and low opacity (instead of grey color and medium opacity).
- Provide a similar drop shadow on the active top level menu item grey arrow
- Fix the "Configure" links on dashboard meta boxes
- Improve meta box style with gradient, as discussed elswhere
- Fix meta box arrow alignment
comment:61
koopersmith — 10 months ago
In [17861]:
comment:62
koopersmith — 10 months ago
In [17862]:
comment:63
koopersmith — 10 months ago
In [17865]:
-
attachment
17324.widget-corners.diff
added
added mouse nibbles to Widget boxes.
comment:64
koopersmith — 10 months ago
In [17866]:
comment:65
koopersmith — 10 months ago
In [17868]:
comment:43
koopersmith — 10 months ago
In [17869]:
comment:44
koopersmith — 10 months ago
In [17870]:
comment:45
kawauso — 10 months ago
There seems to be an extra line added under the Howdy dropdown, but only for super admins: http://awesomescreenshot.com/06aculc15
iammattthomas — 10 months ago
-
attachment
17324.header.diff
added
Patch for header updates I've been working on with Jane today. Smaller site title, larger page title, adjusted style for user-info dropdown, new add-new-h2 style, and removed button class from all add-new-h2 links.
iammattthomas — 10 months ago
-
attachment
header-changes.png
added
Screenshot of changes in 17324.header.diff
comment:46
koopersmith — 10 months ago
In [17872]:
comment:47
follow-up:
↓ 56
koopersmith — 10 months ago
In [17874]:
comment:48
koopersmith — 10 months ago
In [17876]:
comment:49
koopersmith — 10 months ago
In [17881]:
comment:50
koopersmith — 10 months ago
In [17882]:
comment:51
koopersmith — 10 months ago
In [17885]:
-
attachment
17324.publish-box-borders.diff
added
removes the borders between the minor publishing actions in the publish box, as they were too faint against the bg. also adds a 1px #fff shadow to the border above major publishing actions.
comment:52
koopersmith — 10 months ago
In [17892]:
comment:53
koopersmith — 10 months ago
In [17893]:
comment:54
koopersmith — 10 months ago
In [17896]:
comment:55
scribu — 10 months ago
Erm... were's the network admin link?
comment:56
JDTrower — 10 months ago
I can't get a screenshot to show the cursor, but in [17861], the three boxes on the Add/Edit Links page Name, Web Address, and Description show the move cursor even though those three boxes are not moveable. The code responsible is:
.widget .widget-top,
.postbox h3,
.stuffbox h3 {
margin-top: 1px;
border-bottom-width: 1px;
border-style: solid;
cursor: move;
-webkit-user-select: none;
-moz-user-select: none;
-khtml-user-select: none;
user-select: none;
}
My attached patch fixes the problem and I don't see any adverse effects from removing .stuffbox h3 from this CSS code block.
-
attachment
t17324-remove-cursor-move-from-non-movable-boxes.diff
added
Remove cursor: move from non-movable boxes on the Add/Edit Links page.
-
attachment
profile-logout-blue-admin.png
added
Howdy dropdown woth Profile and Logout
comment:57
knutsp — 10 months ago
Blue Admin style has some problems with readability beacuse of bad background on Screen Options, Help and the "Howdy-dropdown". See screenshots as attachments.
(may be I should have added the screenshot images inline instead of as attachmets, sorry)
comment:58
hebbet — 10 months ago
the blue admin style is not ready. see known issues in http://wordpress.org/news/2011/05/wordpress-3-2-beta-1/
comment:59
saracannon — 10 months ago
Uploaded the new arrows for Blue Admin.. and the latest pass at the patch.
comment:60
markjaquith — 10 months ago
saracannon — 10 months ago
-
attachment
nav-menu-port-fix.diff
added
update on the blue as well as porting over colors from nav-menus.css
comment:61
saracannon — 10 months ago
Attached a patch to update the top right drop-down menu in Blue. This patch also ports over color styles from nav-menu.css over to colors-fresh.css and colors-classic.css. Still some color modifications left to do in colors-classic.css on the menus. Also, cleaned up the formatting of nav-menus.css a bit while I was at it.
saracannon — 9 months ago
-
attachment
nav-menu-port-fix02.diff
added
revised update on the blue as well as porting over colors from nav-menus.css
comment:62
saracannon — 9 months ago
Added a revised version of the patch. Now it also includes color edits to the screen options, darken body text color so its not blue.
comment:63
koopersmith — 9 months ago
In [17930]:
comment:64
azaozz — 9 months ago
In [17935]:
comment:66
greuben — 9 months ago
I thought this ticket was closed so I created a new ticket for small visual bug. See #17465
comment:67
tmtrademark — 9 months ago
li.wp-menu-separator still contains an anchor tag ( a.separator ) that targets ?unfoldmenu=1 resulting in a page reload. The cursor no longer changes to the '➞' or '←' types, indicating that you can fold/unfold anymore, so do these still need to be links? I love being subscribed to this thread <3
comment:69
azaozz — 9 months ago
In [17941]:
comment:70
azaozz — 9 months ago
In [17943]:
comment:71
hebbet — 9 months ago
added patch for gradients for login screen, including ie10 and opera
comment:72
greuben — 9 months ago
comment:74
azaozz — 9 months ago
In [17963]:
comment:75
azaozz — 9 months ago
In [17964]:
comment:76
follow-up:
↓ 78
scribu — 9 months ago
Is there any reason why, when hovering over the metabox collapse arrow, the cursor is not made into a pointer? It's meant to be clicked, after all.
comment:77
ocean90 — 9 months ago
Related to scribu: #16440
comment:78
in reply to:
↑ 76
azaozz — 9 months ago
Replying to scribu:
I would rather leave it as cursor:default; but make the arrow go darker on hover. In all browsers the pointer is used for links, the arrow (default) cursor is used for controls and all default controls (look at the Submit button below) have hover effect.
comment:79
scribu — 9 months ago
the arrow (default) cursor is used for controls and all default controls
Yeah, except that's not the case in WP: the widget controls have cursor: pointer on hover, as well as all the buttons.
comment:80
andrewryno — 9 months ago
cursor: pointer; makes more sense to me, which is why I posted the other ticket. A change to a darker color could work, but it just needs to be consistent. I think the way it works on the widget screen, as scribu pointed out, is great. I think all postboxes should act the same way.
comment:81
scribu — 9 months ago
Related: #17534
comment:82
ocean90 — 9 months ago
In my opinion we should standardize the behaviour of the collapse arrows.
- On the navigation the arrow is shown only when the menu is open and hidden when it's closed.
- On the metabox the arrow is hidden when the box is open and closed, so only visible on hover.
- The arrow for screen options and contextual help is always there. The orientation will be changed on a click (Box open = arrow up, box closed = arrow down).
- On the new dropdown menu for user info the arrow is always the same (arrow down).
comment:83
nacin — 9 months ago
They're all different interactions and user experiences, so let's not conflate them.
comment:84
ryan — 9 months ago
- Status changed from accepted to closed
- Resolution set to fixed
Please report further issues on new tickets. Marking this feature ticket as resolved.
comment:85
azaozz — 9 months ago
In [18173]:
comment:86
koopersmith — 9 months ago
In [18223]:
comment:87
koopersmith — 9 months ago
In [18236]:
comment:88
koopersmith — 9 months ago
In [18238]:
comment:89
koopersmith — 9 months ago
In [18258]:






