Opened 2 years ago

Closed 2 years ago

#17362 closed defect (bug) (wontfix)

Use NCRs and boolean attribute with value=attribute's canonical name in Twenty Eleven

Reported by: peaceablewhale Owned by: iandstewart
Priority: normal Milestone: 3.2
Component: Bundled Theme Version: 3.2
Severity: normal Keywords: has-patch
Cc: tom@…

Description

The Twenty Eleven theme is currently using HTML entities to represent some Unicode characters and XHTML-incompatible boolean attribute form. This breaks the page when served as "application/xhtml+xml".

Attachments (1)

17362.patch​ (31.3 KB) - added by peaceablewhale 2 years ago.

Download all attachments as: .zip

Change History (8)

peaceablewhale — 2 years ago

comment:1   peaceablewhale — 2 years ago

Added a well-formness fix for the input element in theme-options.php.

comment:2   holizz — 2 years ago

  • Cc tom@… added

comment:3   peaceablewhale — 2 years ago

  • Owner set to iandstewart
  • Status changed from new to reviewing

comment:4   nacin — 2 years ago

  • Milestone changed from Awaiting Review to 3.2

Input closures, #8217, and pubdate="pubdate" are all fine. We're not compliant with xhtml+xml.

Version 0, edited 2 years ago by nacin (next)

comment:5   westi — 2 years ago

  • Component changed from Themes to Bundled Theme

comment:6   westi — 2 years ago

Please don't replace named entities with magic numbers

Please don't patch auto-generated files.

comment:7   iandstewart — 2 years ago

  • Resolution set to wontfix
  • Status changed from reviewing to closed

Marking this one as wontfix.

Note: See TracTickets for help on using tickets.