Opened 2 years ago
Closed 2 years ago
#17385 closed defect (bug) (fixed)
Post time is missing in Twenty Eleven
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.2 |
| Component: | Bundled Theme | Version: | 3.2 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | lancewillett, iandstewart, mike.schroder@… |
Description
Twenty Eleven only shows post date, but the time is missing.
Attachments (8)
Change History (25)
- Cc lancewillett iandstewart added
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.2
- Owner set to nacin
- Status changed from new to reviewing
Thanks for the patch!
comment:4
iandstewart — 2 years ago
The patch looks good to me.
iandstewart — 2 years ago
comment:5
iandstewart — 2 years ago
author-link-hiding.diff builds on the above patches and adds support for only displaying author links if ismulti_author() returns true.
- Would display: none make more sense and be less cryptic?
- Why not just hide author in PHP using is_multi_author()?
comment:7
iandstewart — 2 years ago
Display none would be less cryptic and PHP simpler but I'd prefer to keep it there for machines and bots to read. I'm open to either though if it means hiding the name for single-author blogs.
We shouldn't hide in PHP but using CSS so a child theme can easily override the decision.
comment:10
nacin — 2 years ago
- Keywords needs-refresh added
Good call on the CSS. Sounds like we just need a patch refresh here. display:none + implements the new function everywhere.
DH-Shredder — 2 years ago
Combination of Newest patches here and #17563, with additional esc_url as appropriate
comment:11
ryan — 2 years ago
Seems that twentyeleven_posted_on() is missing rel="author"
comment:12
DH-Shredder — 2 years ago
- Cc mike.schroder@… added
- Keywords needs-refresh removed
comment:13
iandstewart — 2 years ago
The CSS author hiding if ! is_multI_author() is working as expected for me. As is, resetting with CSS in a child theme.
comment:14
nacin — 2 years ago
In [18244]:
comment:15
aaroncampbell — 2 years ago
I think [18244] introduced an extra </a> in wp-content/themes/twentyeleven/content-image.php on line 35
aaroncampbell — 2 years ago
comment:16
nacin — 2 years ago
In [18257]:
comment:17
ryan — 2 years ago
- Resolution set to fixed
- Status changed from reviewing to closed
Any more escaping can be done on the audit ticket, #17748.

It was displayed via the title attribute in Twenty Ten.
To avoid code duplication we should also create twentyeleven_posted_on() (see twentyten_posted_on()).