Select All checkbox on comment moderation page doesn't uncheck items when unchecked.

[tmtrademark]

On the users, comments and post moderation pages in wp-admin (eg, /wp-admin/edit-comments.php, users.php, edit.php) checking, then unchecking the 'select all' box does not unselect all the displayed items.

How To Reproduce:

1. Log in to wp-admin
2. Navigate to /edit.php
3. Check upper left hand checkbox to 'select all'
4. Uncheck box.
5. Posts (or users or comments) remain checked.

A blog running 3.1.2 does not exhibit this behavior.

Problem occurs even with twentyten and no plugins.

Chrome 13.0.767.1, OS x 10.6

In [17979]:

Fix select all checkboxes JS function, another .attr() vs .prop() case in jQuery 1.6.1, fixes #17527

$(this).prop('checked') could just be this.checked, no?

Replying to scribu:

In theory - yes, in practice I seem to remember some browsers having problems there when checkboxes are checked by JS (it could be old browsers that we no longer support though).

Azaozz, in [17979] is a change related to #17523, by mistake?

Replying to ocean90:

Yes, was testing it and forgot to take it out. But it fixes #17523 so may as well leave it.