Ticket #1785 (closed enhancement: fixed)
Atom-based comment feed
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.2 |
| Component: | General | Version: | 2.1 |
| Severity: | normal | Keywords: | has-patch needs-testing dev-feedback |
| Cc: | rboren |
Description
I've created an Atom 0.3 comment feed. Holizz (holizz.com) updated the code to be Atom 1.0 compliant. It is coded against WordPress 1.5.2.
Attachments
Change History
-
attachment
wp-commentsatom.2.php
added
Fixed incorrect xml:base and id output
- Priority changed from low to normal
Note for the wp-commentsatom.php to work correctly with rewritten urls in Wordpress 2.x this function has to be updated to the following in wp-includes/functions.php
function do_feed_atom($for_comments) {
if ( $for_comments ) {
load_template(ABSPATH . 'wp-commentsatom.php');
} else {
load_template(ABSPATH . 'wp-atom.php');
}
}
Wordpress is WAY overdue to have working ATOM 1.0 feeds and it's super easy to add into the next alpha release with all the groundword already done.
- Keywords dev-feedback added; atom comments feed bg|has-patch removed
- Owner changed from anonymous to rob1n
- Status changed from new to assigned
Is this something that the devs want in the core?
Also, the patch is outdated. I can work on a new one.
Add the template as wp-includes/feed-atom-comments.php.
Update do_feed_atom() to handle withcomments.
Update do_feed() to not assume comment feeds are always rss2.
- Keywords dev-feedback removed
- Version changed from 1.6 to 2.1
I'm on it. :)
comment:10
rob1n — 5 years ago
- Cc rboren added
- Keywords has-patch needs-testing dev-feedback added
Added preliminary patch that NEEDS looking over. I *believe* I did everything right, but then again...
comment:11
rob1n — 5 years ago
Okay, I found one error already: I use bloginfo_rss('content_type') instead of bloginfo_rss('html_type'). I'll fix this in the morning.
comment:12
ryan — 5 years ago
- Status changed from assigned to closed
- Resolution set to fixed
