Opened 2 years ago

Last modified 20 months ago

#17851 reopened enhancement

Wrapping Sections with add_settings_section

Reported by: griffinjt Owned by:
Priority: normal Milestone: Future Release
Component: Administration Version: 3.1.3
Severity: normal Keywords: has-patch
Cc:

Description

This is my first time reporting, so excuse my ignorance. I just wanted to see about enhancing the add_settings_section function.

As of now, individual sections are not wrapper in any sort of container, which makes no sense to semantic sense to me. Sections should/need to be styled differently, but as of now, you really don't have much control of that.

I propose something similar to the register_sidebar function, looking like this:

add_settings_section( $id, $title, $callback, $page, $args )

$args would accept 3 parameters: before_section, after_section, and section_class.

This way you can style each individual section with relative ease. Just a thought and enhancement to the Settings API.

Thomas

Attachments (2)

17851.diff (1.1 KB) - added by scribu 2 years ago.
17851.2.diff (1.2 KB) - added by scribu 2 years ago.
Added settings-field class

Download all attachments as: .zip

Change History (18)

The goal of the settings API is to relieve the developer of any choices of markup and style. Ideally, the core UI styles should be used wherever possible. It also keeps us flexible -- As an example, we plan to kill the table markup in 3.3.

I understand. I just thought it would be nice for UI (e.g. jQuery accordion to keep everything on one page and manageable for lots of options)

Last edited 2 years ago by griffinjt (previous) (diff)

If you need an accordion to keep your options visibly in check, then you probably have too many options :-)

Tushay. :)

This is something that might end up happening in #16413.

I think it would be fine to just have a wrapping div with an ID generated from the section ID.

Easy and functional. I'll look into that then :)

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

I like the idea of automatically adding an id attribute.

Closing as duplicate of #16413

  • Component changed from General to Administration
  • Keywords needs-patch 3.3-early added; ui-feedback removed
  • Milestone set to Future Release
  • Resolution duplicate deleted
  • Status changed from closed to reopened

On second thought, #16413 seems pretty messy.

Automatically wrapping sections in a div and adding id attributes to field rows is a piece of cake.

That would be perfect. Just something to differentiate between sections is all that is needed :)

scribu2 years ago

  • Keywords has-patch added; needs-patch removed

I figured that a "settings-field" class isn't necessary, since you can target fields using .form-table tr

Last edited 2 years ago by scribu (previous) (diff)

They may not remain tables for long.

scribu2 years ago

Added settings-field class

Good point; updated patch.

  • Keywords 3.3-early removed
  • Milestone changed from Future Release to 3.3

If we make no progress on the settings api at all, we can at least do this and it will be a nice step forward.

Agreed. Simple and can let us have a little more control over appearances. :)

  • Milestone changed from 3.3 to Awaiting Review

Punting enhancements from 3.3.

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.