Opened 2 years ago

Last modified 5 months ago

#17884 new enhancement

Remove redundant checks in settings API functions

Reported by: scribu Owned by:
Priority: normal Milestone: Awaiting Review
Component: Administration Version:
Severity: minor Keywords: has-patch settings-api 3.6-early
Cc: me@…, pippin@…

Description

There are several isset() checks in some settings fields functions that are meant to prevent notices, but they're simply unnecessary.

PHP doesn't emit notices in those cases.

Attachments (2)

17884.diff​ (2.0 KB) - added by scribu 2 years ago.
17884.2.diff​ (2.3 KB) - added by scribu 5 months ago.
refresh for WP 3.6-alpha

Download all attachments as: .zip

Change History (10)

scribu — 2 years ago

comment:1   scribu — 2 years ago

  • Severity changed from normal to minor

comment:2   unknowndomain — 5 months ago

  • Keywords settings-3.6 added

comment:3   unknowndomain — 5 months ago

  • Cc me@… added

comment:4   mordauk — 5 months ago

  • Cc pippin@… added

comment:5   ctsttom — 5 months ago

  • Keywords 3.6-early added

@scribu Would you be interested in refreshing this code once 3.5.1 is out in the next couple of weeks to get this into 3.6?

scribu — 5 months ago

refresh for WP 3.6-alpha

comment:6   scribu — 5 months ago

Refreshed.

comment:7   ctsttom — 5 months ago

@scribu I guess that bit hardly changed eh!

comment:8   SergeyBiryukov — 5 months ago

  • Keywords settings-api added; settings-3.6 removed
Note: See TracTickets for help on using tickets.