WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 14 months ago

#17936 closed defect (bug) (fixed)

Prevent accidental multiple click when creating new categories

Reported by: mdawaffe Owned by: westi
Priority: normal Milestone: 3.4
Component: Administration Version: 3.2
Severity: normal Keywords: has-patch commit
Cc:

Description

It is possible to click the "Add New Category" button multiple times when creating a new category from the new post screen.

In certain cases, the extra clicks can cause (mostly harmless) fatal errors because of a race condition in _wp_ajax_add_hierarchical_term().

Attached disables the button via JS after the first click and re-enables it after the AJAX request completes (successfully or not).

Attachments (1)

17936.diff​ (736 bytes) - added by mdawaffe 2 years ago.

Download all attachments as: .zip

Change History (7)

mdawaffe — 2 years ago

comment:1 westi — 2 years ago

  • Owner set to westi
  • Status changed from new to accepted

comment:2 ryan — 17 months ago

  • Milestone changed from Awaiting Review to 3.4

comment:3 nacin — 17 months ago

Looks good.

comment:4 mp3j3rk — 16 months ago

I'm new, but patch looks good to me as well.

Using WordPress 3.3.1 svn rev 20113

Last edited 16 months ago by mp3j3rk (previous) (diff)

comment:5 nacin — 14 months ago

  • Keywords commit added

comment:6 ryan — 14 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

[20650]

Note: See TracTickets for help on using tickets.