Opened 23 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#17950 closed enhancement (fixed)

Introduce wp_registration_url()

Reported by: scribu Owned by: nacin
Priority: low Milestone: 3.6
Component: General Version:
Severity: normal Keywords: has-patch commit needs-codex
Cc: meloniq@…, mail@…

Description (last modified by scribu)

It would be handy to have a wp_registration_url() template tag, to complete the wp_login_url() and wp_logout_url() triad.

Attachments (7)

17950.diff (1.3 KB) - added by scribu 23 months ago.
17950.2.diff (1.1 KB) - added by scribu 23 months ago.
$redirect param isn't useful
17950.3.diff (2.1 KB) - added by scribu 6 months ago.
17950.4.diff (2.1 KB) - added by scribu 6 months ago.
wp_registration_url()
17950.5.diff (2.2 KB) - added by JustinSainton 3 months ago.
17950.6.diff (2.9 KB) - added by JustinSainton 3 months ago.
17950.7.diff (4.2 KB) - added by SergeyBiryukov 3 months ago.
With phpdoc corrections

Download all attachments as: .zip

Change History (27)

$redirect param isn't useful

I noticed that wp-login.php itself never uses wp_login_url() so I didn't use wp_register_url() there either.

Related: #19898

  • Cc meloniq@… added

In 17950.2.diff since wp_register_url is filterable, we should probably esc_url when printing the register link. Also, you might want to remove the $redirect variable since it's undefined and we're not going to be using it anyway :)

scribu6 months ago

Fixed in 17950.3.diff and also use it in wp-login.php.

Something to consider, wp_register_url() could easily be confused to provide functionality to register a URL like register_taxonomy() registers a taxonomy.

Suggestion: Change from verb to noun and use wp_registration_url().

Version 0, edited 6 months ago by MikeSchinkel (next)

scribu6 months ago

wp_registration_url()

  • Description modified (diff)
  • Summary changed from Introduce wp_register_url() to Introduce wp_registration_url()

Good idea!

  • Milestone changed from Future Release to 3.6
  • Priority changed from normal to low
  • Cc mail@… added

We need a decision on the filter name.

17950.4.diff introduces register_url.

#14406 suggests reusing the same register filter we already have in wp_register():
http://core.trac.wordpress.org/browser/tags/3.5/wp-includes/general-template.php#L348

I think 'register_url' is fine, because the 'register' hook contains the whole <a> tag.

comment:12 follow-up: ↓ 13   cartpauj3 months ago

I like wp_register_url() personally.

comment:13 in reply to: ↑ 12   rmccue3 months ago

Replying to cartpauj:

I like wp_register_url() personally.

We have wp_login_url() and wp_logout_url() which are both using the noun form ("login" is the noun, "log in" is the verb). Hence why this is using the noun form.

  • Keywords needs-refresh added

Needs refresh after [23558]. @since 3.3.0 also needs to be updated.

  • Keywords needs-refresh removed

Refreshed.

There are 3 instances of site_url( 'wp-login.php?action=register', 'login' ) in wp-login.php (see [23558] for line numbers), I guess the third one needs to be replaced as well.

Gotta catch 'em all, gotta catch 'em all.

  • Keywords commit added

With phpdoc corrections

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24053:

Add wp_registration_url() and register_url filter.

props scribu, JustinSainton, SergeyBiryukov.
fixes #17950.

  • Keywords needs-codex added
Note: See TracTickets for help on using tickets.