Opened 23 months ago

Closed 23 months ago

Last modified 23 months ago

#17962 closed defect (bug) (fixed)

Twenty Eleven loop is confusing when post is password protected

Reported by: helenyhou Owned by: nacin
Priority: normal Milestone: 3.2.1
Component: Bundled Theme Version: 3.2
Severity: normal Keywords: has-patch
Cc:

Description

When a post is password protected in Twenty Eleven, you get the text "Enter your password to view comments." under the title, followed by "This post is password protected. To view it please enter your password below:" and the usual password form. This seems redundant and looks really confusing. Since it also shows the comments prompt in the entry-meta, perhaps it would be better not to show the icon at all.

Attached is a screenshot of what it looks like in its current state, and a patch to not show the icon if a password is needed. I may (probably) have missed some places, not being as familiar with Twenty Eleven yet.

Attachments (2)

twentyeleven-password.png (37.4 KB) - added by helenyhou 23 months ago.
17962.diff (3.6 KB) - added by helenyhou 23 months ago.

Download all attachments as: .zip

Change History (12)

I really should say the .entry-header .comments-link instead of icon.

Last edited 23 months ago by helenyhou (previous) (diff)
  • Version changed from 3.2 to 3.1.4
  • Version changed from 3.1.4 to 3.2

It appears I changed the version to 3.1.4 thinking I was changing it to 3.2.1. Anyway, this patch looks OK to me.

  • Milestone changed from Awaiting Review to 3.2.1

Does this affect Twenty Ten?

No, Twenty Ten only has a comment link in the entry-meta and it looks fine. It's just because of the slick comment bubble in Twenty Eleven :)

Looks good.

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [18422]:

Twenty Eleven: Don't call comments_popup_link() if post_password_required(). That'll result in double password messages. props helenyhou, fixes #17962 for trunk.

In [18423]:

Twenty Eleven: Don't call comments_popup_link() if post_password_required(). That'll result in double password messages. props helenyhou, fixes #17962 for 3.2.

Note: See TracTickets for help on using tickets.