set_url_scheme() function

[jkudish]

After seeing the idea suggested on ticket #14835 and discussing it in #18005, I thought I'd add in this function which filters a url to return the url with correct protocol (http/https).

Next step would be to implement the function throughout wherever there already is such filtering (or where there should be).

What do you think? Good minor addition to 3.2.x or 3.3?

That's a good start. I think it should have an optional $scheme argument that is handled in the same manner as is done get_site_url(). That way you could pass http, https, admin, login, or login_post if you need to force a particular scheme or context. The default would check is_ssl().

I'll take a look a bit later at get_site_url() and I can send in a new patch shortly.

Thanks!

Here's the updated function with an apply_filters too

How do we go about now adding this function when needed in other places within core?

as Nacin pointed out, I had a little tabbing issue in the diff, here's the update - also following a better naming convention (-# instead of -b)

Related: #19037

Related: #13941, #15928, #19023, #18005

Related: #19037

See wp-hacker's thread titled: "Fixing some SSL cases for 3.4" to follow the evolving discussion.

Refresh, add relative support

unit tests

In [20828]:

Introduce set_url_scheme(). Includes get_site_url() logic for determining when to use http vs. https. Use this to rerite urls to obey is_ssl(). Props jkudish. fixes #18017

​[UT719]